Fix lerna packages #1635
Merged
Fix lerna packages #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virkt25
reviewed
Aug 22, 2018
bin/update-typescript-refs.js
Outdated
| }); | ||
| const tsconfig = require(tsconfigFile); | ||
| const refs = []; | ||
| for (const d of p.localDependencies.keys()) { |
There was a problem hiding this comment.
I'm guessing localDependencies doesn't include packages from npm?
bin/update-typescript-refs.js
Outdated
| } | ||
|
|
||
| const rootTsconfigFile = path.join(project.rootPath, 'tsconfig.json'); | ||
| const rootTsconfig = require(path.join(project.rootPath, 'tsconfig.json')); |
There was a problem hiding this comment.
can be simplified to:
const rootTsConfig = require(rootTsConfigFile);
bin/update-typescript-refs.js
Outdated
| const rootTsconfigJson = JSON.stringify(rootTsconfig, null, 2); | ||
| if (process.argv[2] === '-f') { | ||
| // Using `-f` to overwrite tsconfig.build.json | ||
| fs.writeFileSync(rootTsconfigFile, rootTsconfigJson + '\n', { |
There was a problem hiding this comment.
Any reason to not use await writeFileAsync() ... a promisified version of this api?
| @@ -24,6 +24,12 @@ function run(argv, options) { | |||
| const glob = require('glob'); | |||
| const fse = require('fs-extra'); | |||
|
|
|||
| if (options === true) { | |||
There was a problem hiding this comment.
Should we even allow options to be set as a boolean?
virkt25
reviewed
Aug 22, 2018
raymondfeng
force-pushed
the
fix-lerna-packages
branch
2 times, most recently
from
d69f841 to
46e0772
Compare
raymondfeng
force-pushed
the
fix-lerna-packages
branch
from
46e0772 to
651f73e
Compare
shimks
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how to use lerna to collect packages.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated