Skip to content

refactor(core): use generics for type casting #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2018
Merged

refactor(core): use generics for type casting #1123

merged 1 commit into from
Mar 14, 2018
+4 −4

Conversation

virkt25
Copy link
Contributor

@virkt25 virkt25 commented Mar 12, 2018 •
edited
Loading

came across this while reviewing the code / readme. Making separate PRs for easier review. This usage was introduced in #1050

connected to #988

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Related API Documentation was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

@virkt25 virkt25 self-assigned this Mar 12, 2018
@virkt25 virkt25 added this to the March 2018 milestone Mar 13, 2018
shimks
shimks approved these changes Mar 13, 2018
View reviewed changes
Copy link
Contributor

@shimks shimks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only half listened in on your conversation between Kevin yesterday and was hoping you could explain what was bad and why it was bad.

@virkt25 virkt25 force-pushed the refactor/core branch 3 times, most recently from a626da2 to 5512308 Compare March 13, 2018 20:32
@virkt25
refactor(core): use generics for type casting
302caa5 
came across this while reviewing the code / readme. Making separate PRs for easier review. This usage was introduced in #1050

connected to #988
@virkt25 virkt25 merged commit efa9252 into master Mar 14, 2018
@virkt25 virkt25 deleted the refactor/core branch March 14, 2018 04:18
bajtos
bajtos reviewed Mar 16, 2018
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos left review comments

@raymondfeng raymondfeng raymondfeng approved these changes

@b-admike b-admike b-admike approved these changes

@shimks shimks shimks approved these changes

@kjdelisle kjdelisle Awaiting requested review from kjdelisle

@jannyHou jannyHou Awaiting requested review from jannyHou

@dhmlau dhmlau Awaiting requested review from dhmlau

Assignees

@virkt25 virkt25

Labels
None yet
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@virkt25 @raymondfeng @bajtos @b-admike @shimks