Skip to content

password masking on api key field #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

password masking on api key field #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
975c3ee
switch api key to password hidden field
dzsquared Dec 16, 2022
bcfd83c
correcting input styling
dzsquared Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

# production
/build
/dist

# misc
.DS_Store
Expand Down
49 changes: 37 additions & 12 deletions client/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import {
Stack,
FormControl,
TextField,
OutlinedInput,
InputLabel,
InputAdornment,
IconButton,
Button,
MenuItem,
Typography,
Expand All @@ -10,7 +14,9 @@ import {
debounce,
Box,
LinearProgress,
FormHelperText,
} from "@mui/material";
import { Visibility, VisibilityOff } from "@mui/icons-material";
import React, { useEffect, useState } from "react";
import { createDockerDesktopClient } from "@docker/extension-api-client";
import { Header } from "./Header";
Expand All @@ -28,6 +34,12 @@ function App() {
useApiContext();
const [apikeyError, setApikeyError] = useState(null);

const [showPassword, setShowPassword] = React.useState(false);
const handleClickShowPassword = () => setShowPassword((show) => !show);
const handleMouseDownPassword = (event: React.MouseEvent<HTMLButtonElement>) => {
event.preventDefault();
};

// sample API key: PMAK-6245dae283d9d36ec467cb18-d5a238ce70ed8161d502b30f1db056847b

async function runCommand(collectionID, environmentID, apiKey) {
Expand Down Expand Up @@ -199,18 +211,31 @@ function App() {
) : null}
{!apiKeyInContext || !postmanInfo ? (
<>
<TextField
id="apikey-input"
label={["Postman API key"]}
placeholder="e.g. PMAK-xxx-xxxx-xxxx-xxxx"
error={!!apikeyError}
helperText={apikeyError ? apikeyError : ""}
onChange={(e) => {
validateApikeyError(e.target.value);
}}
focused
fullWidth
/>
<FormControl fullWidth focused sx={{ marginY: 2 }}>
<InputLabel htmlFor="apikey-input">Postman API key</InputLabel>
<OutlinedInput
id="apikey-input"
type={showPassword ? 'text' : 'password'}
placeholder="e.g. PMAK-xxx-xxxx-xxxx-xxxx"
error={!!apikeyError}
onChange={(e) => {
validateApikeyError(e.target.value);
}}
label="Postman API key"
endAdornment={
<InputAdornment position="end">
<IconButton
aria-label="toggle password visibility"
onClick={handleClickShowPassword}
onMouseDown={handleMouseDownPassword}
>
{showPassword ? <VisibilityOff /> : <Visibility />}
</IconButton>
</InputAdornment>
}
/>
<FormHelperText>{apikeyError ? apikeyError : ""}</FormHelperText>
</FormControl>
<Alert severity="info" sx={{ marginY: 2 }}>
Find your Postman API key in{" "}
<Link
Expand Down