Skip to content

Refactoring, Dynamic prefix and AWS v2 (extended) #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

nevins-b
Copy link

@nevins-b nevins-b commented Nov 9, 2016

This is a continuation of @ph's awesome work in #102

This takes into account most of the logic and grammatical changes mentioned in the review of that pull request. It does not do the renaming or deprecation of options.

@ph
Copy link
Contributor

ph commented Nov 9, 2016

@nevins-b Can you sign the CLA?

Would you mind doing step 2 of the contributing guide? https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps

@nevins-b
Copy link
Author

nevins-b commented Nov 9, 2016

@ph Should be all set.

@karmi
Copy link

karmi commented Nov 10, 2016

Hi @nevins-b, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@nevins-b
Copy link
Author

@karmi Added.

@ph
Copy link
Contributor

ph commented Nov 14, 2016

I've merged your commit into #102, there is 7 integrations test that are currently failling taking a look.

@ph ph closed this Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants