Skip to content

Fix build script to run with Gradle 7 #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Oct 18, 2021

Release notes

Update build infrastructure to Gradle 7.2

What does this PR do?

Update the Gradle wrapper used to version 7.2 and fixed build.gradle script.

Why is it important/What is the impact to the user?

Developers can use JDK >= 17 to build the plugin

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Run ./gradlew clean vendor

Related issues

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change LGTM, but this doesn't have to be made into a release, it can just be an entry in the CHANGELOG for a future release.

@andsel andsel force-pushed the fix/update_to_gradle7 branch from 8b85528 to 9739ba4 Compare October 27, 2021 08:29
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit f18e4a3 into logstash-plugins:master Oct 27, 2021
andsel added a commit to andsel/logstash-input-beats that referenced this pull request Oct 28, 2021
…iguration

In PR logstash-plugins#432 the build.gradle was updated to run on Gradle 7, part of the change consisted in
forcing the resolution of 'implementation' configuration to use it in the listing of dependencies.
This could be assolved by the 'runtimeClasspath' without forcing the resolution which smells like a trick.

Relates logstash-plugins#432
andsel added a commit that referenced this pull request Oct 28, 2021
…iguration (#433)

In PR #432 the build.gradle was updated to run on Gradle 7, part of the change consisted in
forcing the resolution of 'implementation' configuration to use it in the listing of dependencies.
This could be assolved by the 'runtimeClasspath' without forcing the resolution which smells like a trick.

Relates #432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants