Adding missing azure services 2 #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently can't use the Azure Device Group in TF as the Azure resources not included get removed (e.g. disks and virtual networks). Not sure if this is useful or if these AZURE resources have been left out for a reason.
Regrettably there are two pull requests as the first one I edited the wrong file (please delete) "adding-missing-azure-services". I've tested this in our Sandbox (basic functional - Azure Resources appear and regression - existing other device groups unaffected).
Apologies if these have been left out for a reason but since I'm going to be using my exe in anger thought this would give you an opportunity to throw the brakes on too.
Regards