only validate secret if we have access to API / default NS exists #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freimer
requested review from
rohitphataklm,
lmshubhashri,
sagar-mamdapure,
lmmahi8may and
lmbhushanpuri
as code owners
|
If someone really cares, or it would cause issues, I can remove the whitespace in the changed lines. |
|
Hi @freimer, We appreciate your pull request. A review of the changes will be conducted. Thanks |
|
See #183 |
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change retrieves the default namespace, and only if that is successful does it validate the user defined secret. During a dry-run (without the server option), the Kubernetes API is not consulted, and any "lookup" values are empty. During an actual install, the default namespace will be found, and the secret validated. Corner-case is if someone actually deletes the default namespace on their cluster, if that is even possible, in which case the install should still work, but the secret will not be validated.