feat(argus): default disable resources #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitphataklm
requested review from
lmvaibhavk,
lmshubhashri,
sagar-mamdapure,
lmbhushanpuri and
guru13-lm
as code owners
charts/argus/templates/_helpers.tpl
Outdated
| @@ -44,6 +44,10 @@ logicmonitor.com/provider: lm-container | |||
|
|
|||
| {{- define "monitoring.disable" }} | |||
| {{ $alwaysDisable := list }} | |||
| {{- if eq .Values.monitoringMode "Minimal" }} | |||
| {{ $alwaysDisable = list "resourcequotas" "limitranges" "roles" "rolebindings" "networkpolicies" "configmaps" "clusterrolebindings" "clusterroles" "priorityclasses" "storageclasses" "cronjobs" "jobs" "endpoints" "ingresses" "secrets" "serviceaccounts" }} | |||
There was a problem hiding this comment.
we can include "poddisruptionbudgets" , "customresourcedefinitions" as well in always disable list for minimal monitoring
lmshubhashri
previously approved these changes
Jan 20, 2025
sagar-mamdapure
approved these changes
Jan 21, 2025
lmbhushanpuri
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default disabled resources
Minimal,Advancedmonitoring options in helm chart.Minimalmonitoring will have limited number of resources enabled in monitoring.Advancedmonitoring will enable all resources to be monitoreddisableBatchedPods, user can enable these Pods if required by toggling the flagAdvancedset in thelm-containerhelm chart. Hence during an upgrade oflm-containerfrom older version, it will preserve the configuration set by user.disableBatchedPodswill be set totrueby default in helm chart. This will ignore the pods created by Jobs / Cronjobs by default.