Add additional convenience methods: process::{dedupe, extract} #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Also, add more usages of AsRef<str> trait bounds instead of directly requesting &str. Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
seanpianka
force-pushed
the
7-remaining-process-methods
branch
from
a740183 to
77afc9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
dedupeandextract, along with a single unit-test for both.However, the dedupe test is failing, as it seems to be returning the shortest duplicate, whereas the "canonical" duplicate is meant to be the longest duplicate (as it contains the most entity information). @logannc, I would appreciate your help debugging this issue... it seems similar to the
max_byissue withextract_onethat required a reversal of the matches.I was going to add
extract_bests, but it does not seem to differ in implementation (beyond defaults) fromextract, so I've commented out the (duplicate) implementation.Closes: #7
Depends on: #15