Repository navigation
Proxy: always add X-Forwarded-Proto alongside X-Forwarded-For - #62
Merged
Merged
Conversation
This header is used by convention to allow downstream servers to reconstruct the original request URL, even if that request to the proxy server was made via a different protocol from that on which the downstream is listening. A typical use case is when the proxy server listens on https but the downstream backend listens on http. We only add this header if not provided by a (further) upstream proxy, and if not explicitly overridden, e.g. by the module-level "forward()" method.
bentsku
approved these changes
Oct 14, 2026
bentsku
left a comment
bentsku
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, nice addition! This might break in a few places downstream where we use the proxy. I need to bump Rolo today so I can take care of fixing this in the bump PR, if we ever need to 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This header is used by convention to allow downstream servers to reconstruct the original request URL, even if that request to the proxy server was made via a different protocol from that on which the downstream is listening. A typical use case is when the proxy server listens on https but the downstream backend listens on http.
Changes
Rolo now ensures this header is always present in requests passed to proxy backends.
We only add this header if not provided by a (further) upstream proxy, and if not explicitly overridden programmatically, e.g. by the module-level
forward()function.