Integration test for start command #4
Draft
+265
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration tests for the
lstk startcommand, showcasing two approaches: Go and Bats.This PR is only a draft for now and I would like to get your opinion @silv-io and only go with one kind of test.
test/integration/start_test.batsuses https://github.com/bats-core/bats-coreThese tests seem simpler to write, they are less verbose and we can be sure they are not reusing code from the CLI (if there's a bug in shared code e.g. config parsing, both CLI and test have the same bug, so it's better to not share any code). However they're not type-safe.
test/integration/start_test.gois testing exactly the same thing but is written in go, which brings simplicity (only one language) and type-safety.