Conversation
whummer
reviewed
Dec 3, 2023
Member
whummer
left a comment
There was a problem hiding this comment.
Great job on this extension @pinzon !
Would like to leave the detailed review to @thrau - he's bee spiking out an extension using LocalAI , perhaps we can somehow unify the two..?
Whatever we decide to do - looking forward to seeing the additional tile for an OpenAI emulator on our Extensions page in the Web app! 🚀
ee03f1f to
dff2007
Compare
Member
|
@pinzon I refactored the extension a bit using utilities introduced in localstack/localstack#10011 i removed the flask app and used rolo instead, now we can serve the app through the localstack gateway :-) You can now use both
WDYT? |
Member
Author
|
@thrau it looks awesome! Thanks for doing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addition of OpenAI Mock Extension to extension catalog