More fixes to scripts - #10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates several Azure deployment scripts to fix Azure CLI argument usage and adjust Key Vault role-assignment behavior in the Key Vault CSI driver samples.
Changes:
- Fix Azure CLI parameter names for PostgreSQL flexible-server firewall rule and database commands.
- Change the Key Vault role assigned to managed identities in Key Vault CSI driver samples (now
Key Vault Administrator). - Minor script edits around role-assignment variables/comments.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| samples/web-app-postgresql-flexible-server/scripts/01-deploy-resources.sh | Updates az postgres flexible-server commands to use correct parameter names for firewall rule and database operations. |
| samples/key-vault-csi-driver/workload-identity/03-create-managed-identity.sh | Changes the Key Vault RBAC role granted to the managed identity and tweaks the role-assignment block. |
| samples/key-vault-csi-driver/user-assigned-managed-identity/03-create-role-assignment.sh | Changes the Key Vault RBAC role granted to the CSI provider identity in the role-assignment script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull requests introduces more fixes.
Changes
The following script were changed:
samples/key-vault-csi-driver/user-assigned-managed-identity/03-create-role-assignment.shsamples/key-vault-csi-driver/workload-identity/03-create-managed-identity.shsamples/web-app-postgresql-flexible-server/scripts/01-deploy-resources.sh