[TORCH] Add support for aten.rms_norm Op #4207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharavana20
force-pushed
the
rms_norm
branch
4 times, most recently
from
3157c21 to
519dc56
Compare
Signed-off-by: sharavana20 <[email protected]>
|
@stellaraccident @vivekkhandelwal1 @penguin-wwy @zjgarvey ,I’d be grateful if any of you could take a look at this PR. Your feedback would be greatly appreciated! |
|
@sharavana20 do you want us to merge this PR? |
@zjgarvey Yes merge the PR. Actually the author's internship stint ended few days back so he can't reply with his account. |
Sorry for the late reply. @zahidwx is right, But I can comment and push any new commits for the older PR with this account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decomposed rms_norm op into Aten ops.
rms(x)=sqrt(eps+mean(x^2))
Added test cases in the e2e part.