Make asuint.64.test compiler agnostic #435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2025 11:18
Amend the test to use literal double values which are encoded to the same binary represenation by both dxc and clang. This allows the expected values to match regardless of which compiler the test instance is using. The encoding of the previous arbitrary values used just happened to differ between dxc and clang, resulting in the test failing when using dxc as the expected values were those produced by clang. Fixes llvm#398 Fixes llvm#415 Fixes llvm#418
Change the failing literal double value to one that (hopefully) is encoded to the same 64 bit pattern by both dxc and clang.
|
With |
|
Hmm, that isn't what I've been seeing locally - I see the difference as in in the reported issues. I'll take another look... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend the test to use literal double values which are encoded to the same binary represenation by both dxc and clang. This allows the expected values to match regardless of which compiler the test instance is using.
The encoding of the previous arbitrary values used just happened to differ between dxc and clang, resulting in the test failing when using dxc as the expected values were those produced by clang.
Fixes #398
Fixes #415
Fixes #418