Skip to content

Enable passing vulkan tests #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 17, 2025
Merged

Enable passing vulkan tests #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
868cf31
Enable passing vulkan tests
s-perron Aug 28, 2025
a362b42
XFAIL failing wave tests.
s-perron Aug 28, 2025
faa5999
Merge branch 'main' into enable-passing-vk-tests
s-perron Sep 6, 2025
ef18211
Merge branch 'main' into enable-passing-vk-tests
s-perron Sep 11, 2025
32ad6bf
Merge branch 'main' into enable-passing-vk-tests
s-perron Sep 12, 2025
38ababd
Merge remote-tracking branch 'origin/enable-passing-vk-tests' into en…
s-perron Sep 12, 2025
d0c8d63
Updated for new versions of clang.
s-perron Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/Feature/Attributes/IfBranchAttr.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ DescriptorSets:
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

# UNSUPPORTED: Clang-Vulkan
# CHECK: Name: In
# CHECK: Format: Int32
# CHECK: Data: [ 1, 4, 9, 16, 25, 36, 49, 64 ]
Expand Down
1 change: 0 additions & 1 deletion test/Feature/Attributes/IfBranchFlatten.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ DescriptorSets:
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

# UNSUPPORTED: Clang-Vulkan
# CHECK: Name: In
# CHECK: Format: Int32
# CHECK: Data: [ 1, 4, 9, 16, 25, 36, 49, 64 ]
Expand Down
7 changes: 4 additions & 3 deletions test/Feature/ImplicitBindings/all-implicit.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,17 @@ DescriptorSets:
...
#--- end

# Clang's Vulkan implicit binding is not yet implemented.
# UNSUPPORTED: Clang-Vulkan
# Unimplemented: CBuffer not implemented in Clang's Vulkan implementation.
# https://github.com/llvm/llvm-project/issues/124597
# XFAIL: Clang-Vulkan

# CBuffer bindings seem to be broken under metal
# https://github.com/llvm/offload-test-suite/issues/55
# UNSUPPORTED: Metal

# RUN: split-file %s %t
# RUN: %if !Vulkan %{ %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl %}
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.3 -fvk-use-scalar-layout -Fo %t.o %t/source.hlsl %}
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.3 -fvk-use-dx-layout -Fo %t.o %t/source.hlsl %}
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

# CHECK: Name: BufC
Expand Down
6 changes: 3 additions & 3 deletions test/Feature/ImplicitBindings/simple-resources.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ DescriptorSets:
Binding: 3
...
#--- end

# Clang's Vulkan implicit binding is not yet implemented.
# UNSUPPORTED: Clang-Vulkan
# Unimplemented: CBuffer not implemented in Clang's Vulkan implementation.
# https://github.com/llvm/llvm-project/issues/124597
# XFAIL: Clang-Vulkan

# DXC's vulkan backend doesn't drop unused bindings, so it isn't possible to
# specify descriptor sets that are valid for both DirectX and Vulkan there.
Expand Down
6 changes: 2 additions & 4 deletions test/Feature/ResourceArrays/array-global.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,9 @@ DescriptorSets:
# Unimplemented https://github.com/llvm/offload-test-suite/issues/305
# XFAIL: Metal

# Bug https://github.com/llvm/llvm-project/issues/149561
# XFAIL: Clang-Vulkan && !VK_KHR_shader_float_controls2

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %if !Vulkan %{ %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl %}
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.3 -fspv-extension=DXC -Fo %t.o %t/source.hlsl %}
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

// These checks added to verify YAML printing of arrays.
Expand Down
5 changes: 1 addition & 4 deletions test/Feature/StructuredBuffer/layout.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,9 @@ DescriptorSets:
...
#--- end

# clang-dxc doesn't support the -fvk-use-scalar-layout flag yet
# UNSUPPORTED: Clang-Vulkan

# RUN: split-file %s %t
# RUN: %if !Vulkan %{ %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl %}
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.3 -fvk-use-scalar-layout -Fo %t.o %t/source.hlsl %}
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.3 -fvk-use-dx-layout -Fo %t.o %t/source.hlsl %}
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

# CHECK: Name: In
Expand Down
2 changes: 0 additions & 2 deletions test/Feature/StructuredBuffer/simple.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ DescriptorSets:
...
#--- end

# UNSUPPORTED: Clang-Vulkan

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s
Expand Down
3 changes: 0 additions & 3 deletions test/Feature/StructuredBuffer/srv.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ DescriptorSets:
...
#--- end

# https://github.com/llvm/llvm-project/issues/140739
# UNSUPPORTED: Clang-Vulkan

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s
Expand Down
1 change: 0 additions & 1 deletion test/Tools/Offloader/BufferFloat-16bit.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ DescriptorSets:

# REQUIRES: Half

# UNSUPPORTED: Clang-Vulkan
# RUN: split-file %s %t
# RUN: %dxc_target -enable-16bit-types -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o
1 change: 0 additions & 1 deletion test/Tools/Offloader/BufferFloat-error-16bit.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ DescriptorSets:

# REQUIRES: Half

# UNSUPPORTED: Clang-Vulkan
# RUN: split-file %s %t
# RUN: %dxc_target -enable-16bit-types -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: not %offloader %t/pipeline.yaml %t.o 2>&1 | FileCheck %s
Expand Down
5 changes: 3 additions & 2 deletions test/UseCase/particle-life.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,8 @@ DescriptorSets:
...
#--- end

# Unimplemented: clang-dxc doesn't support the -fvk-use-scalar-layout flag yet
# Unimplemented: CBuffer not implemented in Clang's Vulkan implementation.
# https://github.com/llvm/llvm-project/issues/124597
# XFAIL: Clang-Vulkan

# CBuffer bindings seem to be broken under metal
Expand All @@ -362,6 +363,6 @@ DescriptorSets:

# RUN: split-file %s %t
# RUN: %if !Vulkan %{ %dxc_target -T cs_6_0 -Fo %t.o %t/particle-life.hlsl %}
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.3 -fvk-use-scalar-layout -Fo %t.o %t/particle-life.hlsl %}
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.3 -fvk-use-dx-layout -Fo %t.o %t/particle-life.hlsl %}
# TODO: Specify -rootsig-define ROOT_SIGNATURE
# RUN: %offloader %t/particle-life.yaml %t.o
Loading