[libc++] Pin down the OS version of macOS runners - #225536
Merged
Merged
Conversation
Otherwise, we sometimes end up using runners that don't have Xcode 26.5 on them. Pinning this allows bumping the version explicitly when we are ready to.
llvmorg-github-actions
Bot
added
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesOtherwise, we sometimes end up using runners that don't have Xcode 26.5 on them. Pinning this allows bumping the version explicitly when we are ready to. Full diff: https://github.com/llvm/llvm-project/pull/225536.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-pr-conformance-tests.yaml b/.github/workflows/libcxx-pr-conformance-tests.yaml
index 21b4a65bd702a..6e333befa9b3c 100644
--- a/.github/workflows/libcxx-pr-conformance-tests.yaml
+++ b/.github/workflows/libcxx-pr-conformance-tests.yaml
@@ -230,7 +230,7 @@ jobs:
xcode-version: '26.5'
- config: apple-system-hardened
xcode-version: '26.5'
- runs-on: ["self-hosted", "macOS", "apple-runners"]
+ runs-on: ["self-hosted", "macOS", "apple-runners", "26.5"] # macOS 26.5, which has Xcode 26.5 too
steps:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
with:
|
|
@llvm/pr-subscribers-github-workflow Author: Louis Dionne (ldionne) ChangesOtherwise, we sometimes end up using runners that don't have Xcode 26.5 on them. Pinning this allows bumping the version explicitly when we are ready to. Full diff: https://github.com/llvm/llvm-project/pull/225536.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-pr-conformance-tests.yaml b/.github/workflows/libcxx-pr-conformance-tests.yaml
index 21b4a65bd702a..6e333befa9b3c 100644
--- a/.github/workflows/libcxx-pr-conformance-tests.yaml
+++ b/.github/workflows/libcxx-pr-conformance-tests.yaml
@@ -230,7 +230,7 @@ jobs:
xcode-version: '26.5'
- config: apple-system-hardened
xcode-version: '26.5'
- runs-on: ["self-hosted", "macOS", "apple-runners"]
+ runs-on: ["self-hosted", "macOS", "apple-runners", "26.5"] # macOS 26.5, which has Xcode 26.5 too
steps:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, we sometimes end up using runners that don't have Xcode 26.5 on them. Pinning this allows bumping the version explicitly when we are ready to.