[Github][Docs] Add testing best practices to CI Best Practices Doc #172235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a practice of making workflows run whenever their workflow definition is changed to make them easy to test. Document this as a best practice to have something to point to during code review.
boomanaiden154
added a commit
to boomanaiden154/offload-test-suite
that referenced
this pull request
Dec 15, 2025
The postcommit workflows set to run as cron jobs are difficult to test without landing changes in main. Add a workflow trigger to run them on pull requests when the workflow definition gets modified. This will also soon be listed in LLVM's CI best practices document soon. llvm/llvm-project#172235 Landing this primarily because it makes it easier to test some changes I want to make soon.
vbvictor
approved these changes
Dec 15, 2025
Keenuts
pushed a commit
to llvm/offload-test-suite
that referenced
this pull request
Dec 15, 2025
The postcommit workflows set to run as cron jobs are difficult to test without landing changes in main. Add a workflow trigger to run them on pull requests when the workflow definition gets modified. This will also soon be listed in LLVM's CI best practices document soon. llvm/llvm-project#172235 Landing this primarily because it makes it easier to test some changes I want to make soon.
tstellar
approved these changes
Dec 15, 2025
cmtice
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a practice of making workflows run whenever their workflow definition is changed to make them easy to test. Document this as a best practice to have something to point to during code review.