[CodeGen] Remove dead hack for MIPS #148039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests pass without it now.
|
@llvm/pr-subscribers-llvm-regalloc Author: AZero13 (AZero13) ChangesAll tests pass without it now. Full diff: https://github.com/llvm/llvm-project/pull/148039.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/LiveVariables.cpp b/llvm/lib/CodeGen/LiveVariables.cpp
index 1f23418642bc6..e857ff665913a 100644
--- a/llvm/lib/CodeGen/LiveVariables.cpp
+++ b/llvm/lib/CodeGen/LiveVariables.cpp
@@ -534,10 +534,6 @@ void LiveVariables::runOnInstr(MachineInstr &MI,
UseRegs.push_back(MOReg);
} else {
assert(MO.isDef());
- // FIXME: We should not remove any dead flags. However the MIPS RDDSP
- // instruction needs it at the moment: http://llvm.org/PR27116.
- if (MOReg.isPhysical() && !MRI->isReserved(MOReg))
- MO.setIsDead(false);
DefRegs.push_back(MOReg);
}
}
|
arsenm
reviewed
Jul 10, 2025
| // FIXME: We should not remove any dead flags. However the MIPS RDDSP | ||
| // instruction needs it at the moment: http://llvm.org/PR27116. | ||
| if (MOReg.isPhysical() && !MRI->isReserved(MOReg)) | ||
| if (!(MOReg.isPhysical() && MRI->isReserved(MOReg))) |
There was a problem hiding this comment.
This isn't removing the hack, this only removes the comment and regresses the style of the condition
There was a problem hiding this comment.
It's not the same condition.
There was a problem hiding this comment.
The condition should be demorganed. The comment also states that dead flags should not be removed, and this is still removing a dead flag
There was a problem hiding this comment.
It just matches the condition in the branch above it
And I actually checked the history of this file, and this was like that before the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests pass without it now.