[LLDB] Mark TestCallStdStringFunction as XPASS on Windows

[Nerixyz]

#146562 made TestCallStdStringFunction unexpectedly pass on Windows.

The test now passes, because expression str now prints the "raw" string object, which happens to include the string "Hello world". Previously, this resulted in an error:

(lldb) expression str
(std::string) $0 = {
  _Mypair = {
    _Myval2 = {
      _Bx = (_Buf = "Hello world", _Ptr = "", _Alias = "Hello world")
      _Mysize = 11
      _Myres = 15
    }
  }
}
(lldb) type summary add std::string --summary-string "${var._M_dataplus._M_p}"
^^^ previous summary ^^^
(lldb) expression str
(std::string) $1 = error: summary string parsing error

#143177 will eventually add the correct summary for MSVC STL strings.

Relates to #22139

[llvmbot]

@llvm/pr-subscribers-lldb

Author: nerix (Nerixyz)

Changes

#146562 made TestCallStdStringFunction unexpectedly pass on Windows.

The test now passes, because expression str now prints the "raw" string object, which happens to include the string "Hello world". Previously, this resulted in an error:

(lldb) expression str
(std::string) $0 = {
  _Mypair = {
    _Myval2 = {
      _Bx = (_Buf = "Hello world", _Ptr = "", _Alias = "Hello world")
      _Mysize = 11
      _Myres = 15
    }
  }
}
(lldb) type summary add std::string --summary-string "${var._M_dataplus._M_p}"
^^^ previous summary ^^^
(lldb) expression str
(std::string) $1 = error: summary string parsing error

#143177 will eventually add the correct summary for MSVC STL strings.

---

Full diff: https://github.com/llvm/llvm-project/pull/146835.diff

1 Files Affected:

• (modified) lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py (+1-1)

diff --git a/lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py b/lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py
index ca2d2d0177eec..bb352b787d72f 100644
--- a/lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py
+++ b/lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py
@@ -9,10 +9,10 @@
 
 
 class ExprCommandCallFunctionTestCase(TestBase):
+
     @expectedFailureAll(
         compiler="icc", bugnumber="llvm.org/pr14437, fails with ICC 13.1"
     )
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     @skipIf(compiler="clang", compiler_version=["<", "9.0"])
     def test_with(self):
         """Test calling std::String member function."""

[Nerixyz]

@slydiman I can't add reviewers, but this should fix the buildbot on Windows. I'm also trying to get Windows premerge checks for LLDB working, so this should hopefully be catched earlier.

[github-actions]

✅ With the latest revision this PR passed the Python code formatter.

[DavidSpickett]

We saw the same thing on Windows on Arm.