[lldb] Rename files ValueObjectSyntheticFilter to ValueObjectSynthetic (NFC)

[kastiglione]

Change the name of ValueObjectSyntheticFilter.{h,cpp} to match the main type they declare and define: ValueObjectSynthetic.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Dave Lee (kastiglione)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/146784.diff

5 Files Affected:

• (modified) lldb/include/lldb/DataFormatters/TypeSynthetic.h (+3-3)
• (renamed) lldb/include/lldb/ValueObject/ValueObjectSynthetic.h (+1-1)
• (modified) lldb/source/ValueObject/CMakeLists.txt (+1-1)
• (modified) lldb/source/ValueObject/ValueObject.cpp (+1-1)
• (renamed) lldb/source/ValueObject/ValueObjectSynthetic.cpp (+2-2)

diff --git a/lldb/include/lldb/DataFormatters/TypeSynthetic.h b/lldb/include/lldb/DataFormatters/TypeSynthetic.h
index 11a4ca2cd8330..b147d66def730 100644
--- a/lldb/include/lldb/DataFormatters/TypeSynthetic.h
+++ b/lldb/include/lldb/DataFormatters/TypeSynthetic.h
@@ -56,10 +56,10 @@ class SyntheticChildrenFrontEnd {
   /// This function is assumed to always succeed and if it fails, the front-end
   /// should know to deal with it in the correct way (most probably, by refusing
   /// to return any children). The return value of \ref Update should actually
-  /// be interpreted as "ValueObjectSyntheticFilter cache is good/bad". If this
+  /// be interpreted as "ValueObjectSynthetic cache is good/bad". If this
   /// function returns \ref lldb::ChildCacheState::eReuse, \ref
-  /// ValueObjectSyntheticFilter is allowed to use the children it fetched
-  /// previously and cached. Otherwise, \ref ValueObjectSyntheticFilter must
+  /// ValueObjectSynthetic is allowed to use the children it fetched
+  /// previously and cached. Otherwise, \ref ValueObjectSynthetic must
   /// throw away its cache, and query again for children.
   virtual lldb::ChildCacheState Update() = 0;
 
diff --git a/lldb/include/lldb/ValueObject/ValueObjectSyntheticFilter.h b/lldb/include/lldb/ValueObject/ValueObjectSynthetic.h
similarity index 98%
rename from lldb/include/lldb/ValueObject/ValueObjectSyntheticFilter.h
rename to lldb/include/lldb/ValueObject/ValueObjectSynthetic.h
index cdb2b1ddc3646..063d796ee4eec 100644
--- a/lldb/include/lldb/ValueObject/ValueObjectSyntheticFilter.h
+++ b/lldb/include/lldb/ValueObject/ValueObjectSynthetic.h
@@ -1,4 +1,4 @@
-//===-- ValueObjectSyntheticFilter.h ----------------------------*- C++ -*-===//
+//===-- ValueObjectSynthetic.h ----------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
diff --git a/lldb/source/ValueObject/CMakeLists.txt b/lldb/source/ValueObject/CMakeLists.txt
index db590f757972a..2a61407521bec 100644
--- a/lldb/source/ValueObject/CMakeLists.txt
+++ b/lldb/source/ValueObject/CMakeLists.txt
@@ -14,7 +14,7 @@ add_lldb_library(lldbValueObject
   ValueObjectList.cpp
   ValueObjectMemory.cpp
   ValueObjectRegister.cpp
-  ValueObjectSyntheticFilter.cpp
+  ValueObjectSynthetic.cpp
   ValueObjectUpdater.cpp
   ValueObjectVariable.cpp
   ValueObjectVTable.cpp
diff --git a/lldb/source/ValueObject/ValueObject.cpp b/lldb/source/ValueObject/ValueObject.cpp
index accfd08b30205..a6fb3fad65251 100644
--- a/lldb/source/ValueObject/ValueObject.cpp
+++ b/lldb/source/ValueObject/ValueObject.cpp
@@ -46,7 +46,7 @@
 #include "lldb/ValueObject/ValueObjectConstResult.h"
 #include "lldb/ValueObject/ValueObjectDynamicValue.h"
 #include "lldb/ValueObject/ValueObjectMemory.h"
-#include "lldb/ValueObject/ValueObjectSyntheticFilter.h"
+#include "lldb/ValueObject/ValueObjectSynthetic.h"
 #include "lldb/ValueObject/ValueObjectVTable.h"
 #include "lldb/lldb-private-types.h"
 
diff --git a/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp b/lldb/source/ValueObject/ValueObjectSynthetic.cpp
similarity index 99%
rename from lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp
rename to lldb/source/ValueObject/ValueObjectSynthetic.cpp
index df774284e4c1b..f673c51a88412 100644
--- a/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp
+++ b/lldb/source/ValueObject/ValueObjectSynthetic.cpp
@@ -1,4 +1,4 @@
-//===-- ValueObjectSyntheticFilter.cpp ------------------------------------===//
+//===-- ValueObjectSynthetic.cpp ------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,7 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "lldb/ValueObject/ValueObjectSyntheticFilter.h"
+#include "lldb/ValueObject/ValueObjectSynthetic.h"
 
 #include "lldb/Core/Value.h"
 #include "lldb/DataFormatters/TypeSynthetic.h"

[labath]

This has bothered me as well.

[jimingham]

I think only Enrico might know why he called it this, and he's not working on lldb anymore.