[CIR] Upstream real for ComplexType #144261

AmrDeveloper · 2025-06-15T12:46:25Z

This change adds support for real for ComplexType

AmrDeveloper · 2025-06-15T12:46:43Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

llvmbot · 2025-06-15T12:48:36Z

@llvm/pr-subscribers-clang

Author: Amr Hesham (AmrDeveloper)

Changes

This change adds support for real for ComplexType

#141365

Full diff: https://github.com/llvm/llvm-project/pull/144261.diff

2 Files Affected:

(modified) clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp (+21)
(modified) clang/test/CIR/CodeGen/complex.cpp (+23)

diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
index 75b4d2a637e6e..615a0e7bef556 100644
--- a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
@@ -603,6 +603,8 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
 
   mlir::Value VisitUnaryLNot(const UnaryOperator *e);
 
+  mlir::Value VisitUnaryReal(const UnaryOperator *e);
+
   mlir::Value VisitCXXThisExpr(CXXThisExpr *te) { return cgf.loadCXXThis(); }
 
   /// Emit a conversion from the specified type to the specified destination
@@ -1891,6 +1893,25 @@ mlir::Value ScalarExprEmitter::VisitUnaryLNot(const UnaryOperator *e) {
   return maybePromoteBoolResult(boolVal, cgf.convertType(e->getType()));
 }
 
+mlir::Value ScalarExprEmitter::VisitUnaryReal(const UnaryOperator *e) {
+  // TODO(cir): handle scalar promotion.
+  Expr *op = e->getSubExpr();
+  if (op->getType()->isAnyComplexType()) {
+    // If it's an l-value, load through the appropriate subobject l-value.
+    // Note that we have to ask E because Op might be an l-value that
+    // this won't work for, e.g. an Obj-C property.
+    if (e->isGLValue())
+      return cgf.emitLoadOfLValue(cgf.emitLValue(e), e->getExprLoc())
+          .getScalarVal();
+
+    // Otherwise, calculate and project.
+    cgf.cgm.errorNYI(e->getSourceRange(),
+                     "VisitUnaryReal calculate and project");
+  }
+
+  return Visit(op);
+}
+
 /// Return the size or alignment of the type of argument of the sizeof
 /// expression as an integer.
 mlir::Value ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr(
diff --git a/clang/test/CIR/CodeGen/complex.cpp b/clang/test/CIR/CodeGen/complex.cpp
index 4bccf65cceb13..3d1e395d7613c 100644
--- a/clang/test/CIR/CodeGen/complex.cpp
+++ b/clang/test/CIR/CodeGen/complex.cpp
@@ -203,3 +203,26 @@ void foo11() {
 
 // OGCG: %[[COMPLEX:.*]] = alloca { double, double }, align 8
 // OGCG: %[[IMAG_PTR:.*]] = getelementptr inbounds nuw { double, double }, ptr %[[COMPLEX]], i32 0, i32 1
+
+void foo12() {
+  double _Complex c;
+  double real = __real__ c;
+}
+
+// CIR: %[[COMPLEX:.*]] = cir.alloca !cir.complex<!cir.double>, !cir.ptr<!cir.complex<!cir.double>>, ["c"]
+// CIR: %[[INIT:.*]] = cir.alloca !cir.double, !cir.ptr<!cir.double>, ["real", init]
+// CIR: %[[REAL_PTR:.*]] = cir.complex.real_ptr %[[COMPLEX]] : !cir.ptr<!cir.complex<!cir.double>> -> !cir.ptr<!cir.double>
+// CIR: %[[REAL:.*]] = cir.load{{.*}} %[[REAL_PTR]] : !cir.ptr<!cir.double>, !cir.double
+// CIR: cir.store{{.*}} %[[REAL]], %[[INIT]] : !cir.double, !cir.ptr<!cir.double>
+
+// LLVM: %[[COMPLEX:.*]] = alloca { double, double }, i64 1, align 8
+// LLVM: %[[INIT:.*]] = alloca double, i64 1, align 8
+// LLVM: %[[REAL_PTR:.*]] = getelementptr inbounds nuw { double, double }, ptr %[[COMPLEX]], i32 0, i32 0
+// LLVM: %[[REAL:.*]] = load double, ptr %[[REAL_PTR]], align 8
+// LLVM: store double %[[REAL]], ptr %[[INIT]], align 8
+
+// OGCG: %[[COMPLEX:.*]] = alloca { double, double }, align 8
+// OGCG: %[[INIT:.*]] = alloca double, align 8
+// OGCG: %[[REAL_PTR:.*]] = getelementptr inbounds nuw { double, double }, ptr %[[COMPLEX]], i32 0, i32 0
+// OGCG: %[[REAL:.*]] = load double, ptr %[[REAL_PTR]], align 8
+// OGCG: store double %[[REAL]], ptr %[[INIT]], align 8

llvmbot · 2025-06-15T12:48:37Z

@llvm/pr-subscribers-clangir

Author: Amr Hesham (AmrDeveloper)

Changes

This change adds support for real for ComplexType

#141365

Full diff: https://github.com/llvm/llvm-project/pull/144261.diff

2 Files Affected:

(modified) clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp (+21)
(modified) clang/test/CIR/CodeGen/complex.cpp (+23)

diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
index 75b4d2a637e6e..615a0e7bef556 100644
--- a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
@@ -603,6 +603,8 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
 
   mlir::Value VisitUnaryLNot(const UnaryOperator *e);
 
+  mlir::Value VisitUnaryReal(const UnaryOperator *e);
+
   mlir::Value VisitCXXThisExpr(CXXThisExpr *te) { return cgf.loadCXXThis(); }
 
   /// Emit a conversion from the specified type to the specified destination
@@ -1891,6 +1893,25 @@ mlir::Value ScalarExprEmitter::VisitUnaryLNot(const UnaryOperator *e) {
   return maybePromoteBoolResult(boolVal, cgf.convertType(e->getType()));
 }
 
+mlir::Value ScalarExprEmitter::VisitUnaryReal(const UnaryOperator *e) {
+  // TODO(cir): handle scalar promotion.
+  Expr *op = e->getSubExpr();
+  if (op->getType()->isAnyComplexType()) {
+    // If it's an l-value, load through the appropriate subobject l-value.
+    // Note that we have to ask E because Op might be an l-value that
+    // this won't work for, e.g. an Obj-C property.
+    if (e->isGLValue())
+      return cgf.emitLoadOfLValue(cgf.emitLValue(e), e->getExprLoc())
+          .getScalarVal();
+
+    // Otherwise, calculate and project.
+    cgf.cgm.errorNYI(e->getSourceRange(),
+                     "VisitUnaryReal calculate and project");
+  }
+
+  return Visit(op);
+}
+
 /// Return the size or alignment of the type of argument of the sizeof
 /// expression as an integer.
 mlir::Value ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr(
diff --git a/clang/test/CIR/CodeGen/complex.cpp b/clang/test/CIR/CodeGen/complex.cpp
index 4bccf65cceb13..3d1e395d7613c 100644
--- a/clang/test/CIR/CodeGen/complex.cpp
+++ b/clang/test/CIR/CodeGen/complex.cpp
@@ -203,3 +203,26 @@ void foo11() {
 
 // OGCG: %[[COMPLEX:.*]] = alloca { double, double }, align 8
 // OGCG: %[[IMAG_PTR:.*]] = getelementptr inbounds nuw { double, double }, ptr %[[COMPLEX]], i32 0, i32 1
+
+void foo12() {
+  double _Complex c;
+  double real = __real__ c;
+}
+
+// CIR: %[[COMPLEX:.*]] = cir.alloca !cir.complex<!cir.double>, !cir.ptr<!cir.complex<!cir.double>>, ["c"]
+// CIR: %[[INIT:.*]] = cir.alloca !cir.double, !cir.ptr<!cir.double>, ["real", init]
+// CIR: %[[REAL_PTR:.*]] = cir.complex.real_ptr %[[COMPLEX]] : !cir.ptr<!cir.complex<!cir.double>> -> !cir.ptr<!cir.double>
+// CIR: %[[REAL:.*]] = cir.load{{.*}} %[[REAL_PTR]] : !cir.ptr<!cir.double>, !cir.double
+// CIR: cir.store{{.*}} %[[REAL]], %[[INIT]] : !cir.double, !cir.ptr<!cir.double>
+
+// LLVM: %[[COMPLEX:.*]] = alloca { double, double }, i64 1, align 8
+// LLVM: %[[INIT:.*]] = alloca double, i64 1, align 8
+// LLVM: %[[REAL_PTR:.*]] = getelementptr inbounds nuw { double, double }, ptr %[[COMPLEX]], i32 0, i32 0
+// LLVM: %[[REAL:.*]] = load double, ptr %[[REAL_PTR]], align 8
+// LLVM: store double %[[REAL]], ptr %[[INIT]], align 8
+
+// OGCG: %[[COMPLEX:.*]] = alloca { double, double }, align 8
+// OGCG: %[[INIT:.*]] = alloca double, align 8
+// OGCG: %[[REAL_PTR:.*]] = getelementptr inbounds nuw { double, double }, ptr %[[COMPLEX]], i32 0, i32 0
+// OGCG: %[[REAL:.*]] = load double, ptr %[[REAL_PTR]], align 8
+// OGCG: store double %[[REAL]], ptr %[[INIT]], align 8

andykaylor · 2025-06-16T19:31:43Z

My comments on #144235 apply more directly here, of course.

bcardosolopes · 2025-06-17T18:19:57Z

This might look a bit different given the redesign of the other pieces, so I'm gonna hold on reviewing this for now, let me know when this is ready again.

github-actions · 2025-06-21T12:03:59Z

✅ With the latest revision this PR passed the C/C++ code formatter.

AmrDeveloper · 2025-06-23T16:14:55Z

This PR is ready to review now with the new design from the incubator @bcardosolopes @andykaylor

andykaylor

lgtm with one nit. Can you also add a test for the verifier?

andykaylor · 2025-06-23T23:56:24Z

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp

+  Expr *op = e->getSubExpr();
+  if (op->getType()->isAnyComplexType()) {
+    // If it's an l-value, load through the appropriate subobject l-value.
+    // Note that we have to ask E because Op might be an l-value that


Suggested change

// Note that we have to ask E because Op might be an l-value that

// Note that we have to ask `e` because `op` might be an l-value that

AmrDeveloper · 2025-06-24T17:05:22Z

I updated the error message; previously, the op name was printed twice

unexpected error: 'cir.complex.real' op cir.complex.real result type does not match operand type

Now

unexpected error: 'cir.complex.real' op : result type does not match operand type

This change adds support for __real__ for ComplexType llvm#141365

This was referenced Jun 15, 2025

[CIR] Upstream ComplexRealPtrOp for ComplexType #144235

Open

[CIR] Upstream ComplexImagPtrOp for ComplexType #144236

Open

AmrDeveloper mentioned this pull request Jun 15, 2025

[CIR] Upstream __imag__ for ComplexType #144262

Merged

AmrDeveloper requested review from xlauko, mmha, erichkeane and andykaylor June 15, 2025 12:47

AmrDeveloper marked this pull request as ready for review June 15, 2025 12:48

AmrDeveloper requested review from lanza and bcardosolopes as code owners June 15, 2025 12:48

llvmbot added clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project labels Jun 15, 2025

AmrDeveloper changed the base branch from users/amrdeveloper/cir-upstream-complex-imag-ptr to main June 21, 2025 11:57

AmrDeveloper force-pushed the users/amrdeveloper/cir-upstream-complex-real-expr branch from 9cbbfd2 to 0e4fd68 Compare June 21, 2025 12:01

[CIR] Upstream __real__ for ComplexType

4df7f79

AmrDeveloper force-pushed the users/amrdeveloper/cir-upstream-complex-real-expr branch from 0e4fd68 to 4df7f79 Compare June 21, 2025 12:04

bcardosolopes approved these changes Jun 23, 2025

View reviewed changes

andykaylor approved these changes Jun 24, 2025

View reviewed changes

Add test for verifier

79346d3

AmrDeveloper merged commit 9a7720a into main Jun 25, 2025
6 of 7 checks passed

AmrDeveloper deleted the users/amrdeveloper/cir-upstream-complex-real-expr branch June 25, 2025 16:06

anthonyhatran pushed a commit to anthonyhatran/llvm-project that referenced this pull request Jun 26, 2025

[CIR] Upstream __real__ for ComplexType (llvm#144261)

ff33f69

This change adds support for __real__ for ComplexType llvm#141365

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CIR] Upstream real for ComplexType #144261

[CIR] Upstream real for ComplexType #144261

Uh oh!

AmrDeveloper commented Jun 15, 2025 •

edited

Loading

Uh oh!

AmrDeveloper commented Jun 15, 2025 •

edited

Loading

Uh oh!

llvmbot commented Jun 15, 2025

Uh oh!

llvmbot commented Jun 15, 2025

Uh oh!

andykaylor commented Jun 16, 2025

Uh oh!

bcardosolopes commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 21, 2025 •

edited

Loading

Uh oh!

AmrDeveloper commented Jun 23, 2025

Uh oh!

andykaylor left a comment

Uh oh!

andykaylor Jun 23, 2025

Uh oh!

AmrDeveloper commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

	// Note that we have to ask E because Op might be an l-value that
	// Note that we have to ask `e` because `op` might be an l-value that

[CIR] Upstream __real__ for ComplexType #144261

[CIR] Upstream __real__ for ComplexType #144261

Uh oh!

Conversation

AmrDeveloper commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmrDeveloper commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Jun 15, 2025

Uh oh!

llvmbot commented Jun 15, 2025

Uh oh!

andykaylor commented Jun 16, 2025

Uh oh!

bcardosolopes commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmrDeveloper commented Jun 23, 2025

Uh oh!

andykaylor left a comment

Choose a reason for hiding this comment

Uh oh!

andykaylor Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

AmrDeveloper commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

[CIR] Upstream real for ComplexType #144261

[CIR] Upstream real for ComplexType #144261

AmrDeveloper commented Jun 15, 2025 •

edited

Loading

AmrDeveloper commented Jun 15, 2025 •

edited

Loading

github-actions bot commented Jun 21, 2025 •

edited

Loading