[llvm] Build Windows release package with clang-cl if possible #135446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmodem
approved these changes
Apr 14, 2025
zmodem
reviewed
Jul 18, 2025
|
|
||
| if "%force-msvc%" == "" ( | ||
| where /q clang-cl | ||
| if errorlevel 0 ( |
There was a problem hiding this comment.
I suppose I should have caught this in review, but I ran into it when building 20.1.0-rc1 instead :-)
Apparently if errorlevel 0 will succeed if the error level is >= 0, i.e. in our case we will take the branch also when where /q clang-cl is not successful. (E.g. https://devblogs.microsoft.com/oldnewthing/20080926-00/?p=20743)
I'll work around this by passing --force-msvc, but it also needs to be fixed.
aganea
added a commit
that referenced
this pull request
Aug 19, 2025
… in PATH (#149597) The checks for detecting if `clang-cl` and `lld-link` are in `%PATH` were wrong. This fixes the comment in #135446 (comment)
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 19, 2025
…clang-cl is in PATH (#149597) The checks for detecting if `clang-cl` and `lld-link` are in `%PATH` were wrong. This fixes the comment in llvm/llvm-project#135446 (comment)
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 21, 2025
… in PATH (llvm#149597) The checks for detecting if `clang-cl` and `lld-link` are in `%PATH` were wrong. This fixes the comment in llvm#135446 (comment) (cherry picked from commit 13391ce)
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 21, 2025
…clang-cl is in PATH (#149597) The checks for detecting if `clang-cl` and `lld-link` are in `%PATH` were wrong. This fixes the comment in llvm/llvm-project#135446 (comment) (cherry picked from commit 13391ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
clang-cl.exeandlld-link.exeare installed in%PATH%, the Windows release build script will now use these by default, in place of MSVC. The reason for doing this is that MSVC still has, for the past year(s), a O(N^2) behavior when building certain LLVM source files, which leads to long build times (minutes per file). A report was filled here: https://developercommunity.visualstudio.com/t/ON2-in-SparseBitVectorBase-when-com/10657991I also added a
--force-msvcoption to the script, to use MSVC even if clang-cl is installed.