Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang] Rename ReadPCHAndPreprocessAction (NFC) #122390

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/include/clang/Frontend/FrontendActions.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ class InitOnlyAction : public FrontendAction {
bool usesPreprocessorOnly() const override { return false; }
};

/// Preprocessor-based frontend action that also loads PCH files.
class ReadPCHAndPreprocessAction : public FrontendAction {
/// Preprocessor-based frontend action that is used for dependency scanning.
class DependencyScanningFrontendAction : public FrontendAction {
void ExecuteAction() override;

std::unique_ptr<ASTConsumer> CreateASTConsumer(CompilerInstance &CI,
Expand Down
6 changes: 3 additions & 3 deletions clang/lib/Frontend/FrontendActions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void InitOnlyAction::ExecuteAction() {
}

// Basically PreprocessOnlyAction::ExecuteAction.
void ReadPCHAndPreprocessAction::ExecuteAction() {
void DependencyScanningFrontendAction::ExecuteAction() {
Preprocessor &PP = getCompilerInstance().getPreprocessor();

// Ignore unknown pragmas.
Expand All @@ -84,8 +84,8 @@ void ReadPCHAndPreprocessAction::ExecuteAction() {
}

std::unique_ptr<ASTConsumer>
ReadPCHAndPreprocessAction::CreateASTConsumer(CompilerInstance &CI,
StringRef InFile) {
DependencyScanningFrontendAction::CreateASTConsumer(CompilerInstance &CI,
StringRef InFile) {
return std::make_unique<ASTConsumer>();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ class DependencyScanningAction : public tooling::ToolAction {
else if (ModuleName)
Action = std::make_unique<GetDependenciesByModuleNameAction>(*ModuleName);
else
Action = std::make_unique<ReadPCHAndPreprocessAction>();
Action = std::make_unique<DependencyScanningFrontendAction>();

if (ScanInstance.getDiagnostics().hasErrorOccurred())
return false;
Expand Down
Loading