-
Notifications
You must be signed in to change notification settings - Fork 165
[CIR][CodeGen] Attach hot attribute to CIR function #1826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits
Also, if you didn't already, try using mlir/utils/generate_test_checks.py
to generate test checks automatically with a uniform format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
If you can revert those formatting changes it would be appreciated. I try to only format the code regions that I change to avoid getting myself in the blame chain :^)
Hey @bcardosolopes. Will you run CI checks for this PR again now that the issues with clang-tidy were fixed (I think)? |
Sure, once you land the first PR these will be triggered automatically! |
Implemented missing feature for issue #1793. Also implemented LLVM lowering for the hot attribute, and added a new test case.