Babelstream #910
Open
Babelstream #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
experiment
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #910 +/- ##
========================================
Coverage 40.82% 40.82%
========================================
Files 22 22
Lines 1536 1536
Branches 219 219
========================================
Hits 627 627
Misses 864 864
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
scheibelp
reviewed
Sep 10, 2025
| import re # To get the variant name after (+) | ||
|
|
||
| from spack.package import * | ||
| from spack.pkg.builtin.babelstream import Babelstream as BuiltinBabel |
Collaborator
There was a problem hiding this comment.
referring to builtin changed w/ #953 - see https://github.com/LLNL/benchpark/blob/develop/repo/blt/package.py for example of how to import from builtin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the babelstream benchmark. Supersedes #639. Closes #615.
Tested on tuolumne (openmp, rocm modes) and matrix (cuda mode)
Currently the application uses a source repo that implements caliper. The following steps must be completed before this PR can be merged
Adding/modifying a benchmark (docs: Adding a Benchmark)
repo/benchmark_name/package.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.experiments/benchmark_name/experiment.pyto define a single node and multi-node experiments.github/workflows/run.yml