add a text queue to be able to ignore unexpected gdb output; handle r…#32
Open
johnlvogt wants to merge 1 commit intollnl:developfrom
Open
add a text queue to be able to ignore unexpected gdb output; handle r…#32johnlvogt wants to merge 1 commit intollnl:developfrom
johnlvogt wants to merge 1 commit intollnl:developfrom
Conversation
…ocgdb startup behavior
Codecov Report
@@ Coverage Diff @@
## develop #32 +/- ##
========================================
Coverage 44.50% 44.50%
========================================
Files 10 10
Lines 6465 6465
========================================
Hits 2877 2877
Misses 3588 3588 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version just read output from gdb from a stream, but this proved brittle because if gdb produced extra output, gdb.py would return the result from the previous command for every ensuing command. This version reads the gdb output on a separate thread which keeps it from blocking if the gdb doesn't produce output when expected, and also allows each operation to flush any unprocessed output from the previous command.
There is also a section of changes related to rocgdb specific changes in the format for thread info.