DRAFT: MFEM kernel updates #609
Draft
+2,218
−516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artv3
commented
Jan 5, 2026
src/apps/MASS3DPA_ATOMIC.hpp
Outdated
| /// for(int dx=0; dx<mpa3d_at::D1D; ++dx) { | ||
| /// int j = dx + mpa3d_at::D1D * (dy + dz * mpa3d_at::D1D); | ||
| /// //missing dof_map for lexicographical ordering | ||
| /// thread_dofs[j] = m_elemToDoF[j + mpa3d_at::D1D * mpa3d_at::D1D * |
Member
Author
There was a problem hiding this comment.
@tomstitt , I have here the first cut of the action of the mass matrix with atomics... Not sure how important this is by I currently left out the missing dof_map which gives us the lexicographical ordering....
artv3
commented
Jan 5, 2026
| MASS3DPA_ATOMIC_3; | ||
| } | ||
|
|
||
| SHARED_LOOP_3D(qx, qy, dz, mpa3d_at::Q1D, mpa3d_at::Q1D, mpa3d_at::D1D) { |
Member
Author
There was a problem hiding this comment.
@llnl/raja-core , what do you guys think of name-spacing the constants?
artv3
commented
Jan 6, 2026
|
|
||
| //How does this work?? | ||
| //getTargetProblemSize(); | ||
| //m_NE = std::max(static_cast<Index_type>( (getTargetProblemSize() + , Index_type(1)); |
Member
Author
There was a problem hiding this comment.
@MrBurmark , I'm a bit confused here. How do incorporate the getTargetProblemSize() into our calculation?
Member
There was a problem hiding this comment.
That's the value that comes in from the command line for size.
If this kernel is the same as the non-atomic version of this kernel then this whole file should be almost identical to MASS3DPA.cpp.
artv3
commented
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR addresses issues: #578 along with major clean up passes...
Relevant kernels will be checked to be consistent with MFEM-4.9. FOM will be updated to be the DOF
Checklist: