-
Notifications
You must be signed in to change notification settings - Fork 24
Trigger hook on parent array property #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If we are going to merge this it should probably handle your last case of deep subkeys. |
Mark as ready for review again when you want me to take another look please. Thanks! |
Added support for deep subkeys. Hope the codebase is still in line with the package behaviour. |
Hello @taylorotwell any comment ? |
@taylorotwell let me know if there is something you want me to adjust. |
@undjike @taylorotwell any updates on this PR? |
Any updates here? |
Is there any update on this issue? |
This PR addresses issue #107.
It allows triggering the update hook on the parent array property when a change is made to a key.
Before :
When updating on a key, the hook is only triggered for that key.
With this PR :
When updating on a key, the hook is triggered on the parent array, if not explicitly listening for changes to the key.
That said... I'm wondering whether we should make it more dynamic to handle deep subkey as well.
This PR will forward the hook to the parent property
profiles
not toprofiles.admin
.