Fix runtime injection for decorated Blade engines#94
Closed
prateekbhujel wants to merge 1 commit intolivewire:mainfrom
Closed
Fix runtime injection for decorated Blade engines#94prateekbhujel wants to merge 1 commit intolivewire:mainfrom
prateekbhujel wants to merge 1 commit intolivewire:mainfrom
Conversation
Contributor
Author
|
I reproduced the regression with a decorated Blade engine and confirmed the undefined Validation steps I ran locally:
|
Collaborator
|
Thanks for contributing however this feels like a very hacky solution. |
Contributor
Author
|
Thanks for the candid feedback. You’re right that this approach adds too much complexity for this path. I’ll leave this here and won’t push further changes on this topic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a regression in v1.0.3 where Blaze runtime injection can be skipped when the Blade engine is wrapped by a decorator (for example Sentry's
ViewEngineDecorator).What changed
getEngine()until aCompilerEngineis found__blazeWhy this is needed
In the current code,
registerBlazeRuntime()only checksinstanceof CompilerEngineon the top-level engine object. Decorators are notCompilerEngine, so__blazeis not injected and compiled views can fail withUndefined variable $__blaze.Verification
injects blaze runtime when blade engine is decoratedvendor/bin/pest)