Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
Installing Blaze alongside Statamic and visiting any Statamic page that uses a
{{ nocache }}tag throws an exceptionThe problem
View::share()injects data into every view engine registered in Laravel -- not just Blade.BlazeRuntimewas shared globally viaView::share('__blaze', ...), which meant it landed in Statamic's Antlers template context too.Statamic's
{{ nocache }}feature serializes the template context so it can replay dynamic sections from cache.BlazeRuntimeholds the Application container and the Blade compiler, both of which contain Closures that can't be serialized:This happened even with
BLAZE_ENABLED=falsebecause theView::share()call ran unconditionally inboot().The solution
Replace
View::share()with aView::composer('*', ...)that checks$view->getEngine() instanceof CompilerEnginebefore injecting__blaze. This scopes the runtime to Blade views only and keeps it out of Antlers and any other non-Blade engine.Fixes #83