Skip to content

Conversation

@mjh1
Copy link
Contributor

@mjh1 mjh1 commented Sep 29, 2025

We think we may be hitting max price at some points resulting in no capacity for live AI, these changes will allow us to confirm this.

  • Record O price in a metric
  • Emit a log if an O is above our max price

@github-actions github-actions bot added the go Pull requests that update Go code label Sep 29, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.05354%. Comparing base (88807fa) to head (280d222).

Files with missing lines Patch % Lines
monitor/census.go 58.33333% 5 Missing ⚠️
discovery/discovery.go 0.00000% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3759         +/-   ##
===================================================
+ Coverage   33.05093%   33.05354%   +0.00261%     
===================================================
  Files            160         160                 
  Lines          40250       40268         +18     
===================================================
+ Hits           13303       13310          +7     
- Misses         25904       25915         +11     
  Partials        1043        1043                 
Files with missing lines Coverage Δ
server/selection_algorithm.go 90.66667% <100.00000%> (+0.25571%) ⬆️
discovery/discovery.go 70.66667% <0.00000%> (-1.27903%) ⬇️
monitor/census.go 62.22381% <58.33333%> (-0.03356%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88807fa...280d222. Read the comment docs.

Files with missing lines Coverage Δ
server/selection_algorithm.go 90.66667% <100.00000%> (+0.25571%) ⬆️
discovery/discovery.go 70.66667% <0.00000%> (-1.27903%) ⬇️
monitor/census.go 62.22381% <58.33333%> (-0.03356%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mjh1 mjh1 requested a review from leszko November 5, 2025 14:32
@mjh1 mjh1 marked this pull request as ready for review November 5, 2025 14:32
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to also add some logs in in the place where we reject O because of the price. That could help us investigate the issues we've seen recently.

I think we could have a condition that if no orchestrator addrs is returned, then log the gateway's max price and all the prices from Orchestrators.

@mjh1
Copy link
Contributor Author

mjh1 commented Nov 6, 2025

I'd suggest to also add some logs in in the place where we reject O because of the price. That could help us investigate the issues we've seen recently.

I think we could have a condition that if no orchestrator addrs is returned, then log the gateway's max price and all the prices from Orchestrators.

@leszko shouldn't this do the job? https://github.com/livepeer/go-livepeer/pull/3759/files#diff-59e9c6e443e499e5834193b55a55e74ded9b66ee74289845a81b1966d99371ceR83

@leszko
Copy link
Contributor

leszko commented Nov 6, 2025

I'd suggest to also add some logs in in the place where we reject O because of the price. That could help us investigate the issues we've seen recently.

I think we could have a condition that if no orchestrator addrs is returned, then log the gateway's max price and all the prices from Orchestrators.

@leszko shouldn't this do the job? https://github.com/livepeer/go-livepeer/pull/3759/files#diff-59e9c6e443e499e5834193b55a55e74ded9b66ee74289845a81b1966d99371ceR83

Ahh, yeah. I think that's fine.

@mjh1 mjh1 merged commit c492248 into master Nov 7, 2025
15 of 16 checks passed
@mjh1 mjh1 deleted the mh/price-metric branch November 7, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants