-
Notifications
You must be signed in to change notification settings - Fork 205
Publish price in a metric #3759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3759 +/- ##
===================================================
+ Coverage 33.05093% 33.05354% +0.00261%
===================================================
Files 160 160
Lines 40250 40268 +18
===================================================
+ Hits 13303 13310 +7
- Misses 25904 25915 +11
Partials 1043 1043
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
leszko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to also add some logs in in the place where we reject O because of the price. That could help us investigate the issues we've seen recently.
go-livepeer/server/selection_algorithm.go
Line 84 in 7509bd6
| return res |
I think we could have a condition that if no orchestrator addrs is returned, then log the gateway's max price and all the prices from Orchestrators.
@leszko shouldn't this do the job? https://github.com/livepeer/go-livepeer/pull/3759/files#diff-59e9c6e443e499e5834193b55a55e74ded9b66ee74289845a81b1966d99371ceR83 |
Ahh, yeah. I think that's fine. |
We think we may be hitting max price at some points resulting in no capacity for live AI, these changes will allow us to confirm this.