Skip to content

Revert "fix: temporarily compute the LIP-118 tally on-chain while the subgraph resyncs"#750

Merged
rickstaa merged 1 commit into
mainfrom
revert-749-fix/lip118-onchain-poll-tally
Jul 22, 2026
Merged

Revert "fix: temporarily compute the LIP-118 tally on-chain while the subgraph resyncs"#750
rickstaa merged 1 commit into
mainfrom
revert-749-fix/lip118-onchain-poll-tally

Conversation

@rickstaa

Copy link
Copy Markdown
Member

Reverts #749 when subgraph is done indexing (see livepeer/subgraph#247)).

Copilot AI review requested due to automatic review settings July 21, 2026 17:34
@rickstaa
rickstaa requested a review from ECWireless as a code owner July 21, 2026 17:34
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
explorer-arbitrum-one Ready Ready Preview, Comment Jul 21, 2026 5:37pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@rickstaa, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: acae3e81-b2fc-4634-a96e-e8343d7cac30

📥 Commits

Reviewing files that changed from the base of the PR and between 98f5694 and 28bade8.

📒 Files selected for processing (7)
  • constants/manualPolls.ts
  • hooks/useSwr.tsx
  • lib/api/pollTally.ts
  • lib/api/polls.ts
  • lib/api/types/get-poll-tally.ts
  • pages/api/polls/tally/[poll].ts
  • pages/voting/[poll].tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-749-fix/lip118-onchain-poll-tally

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the temporary “compute poll tally on-chain” stopgap (introduced while the subgraph was behind) now that the subgraph has finished indexing again.

Changes:

  • Removes the API route, types, and helper that computed/served poll tallies directly from chain state.
  • Removes the client SWR hook and UI-side wiring that overlaid on-chain tallies / “did I vote?” state for manual polls.
  • Simplifies manual poll entries to be subgraph-shaped placeholders without on-chain tally metadata.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pages/voting/[poll].tsx Removes manual on-chain tally/vote fallback logic and updates the “indexing” notice copy.
pages/api/polls/tally/[poll].ts Deletes the temporary API endpoint that served on-chain computed tallies.
lib/api/types/get-poll-tally.ts Deletes the temporary PollTally types used by the stopgap endpoint/hook.
lib/api/pollTally.ts Deletes the on-chain tally computation implementation.
lib/api/polls.ts Removes the on-chain total-stake fallback and keeps only subgraph-based total stake fetching.
hooks/useSwr.tsx Removes the useManualPollTally SWR hook.
constants/manualPolls.ts Removes manual poll startBlockL2 / tally-overlay helper, leaving manual polls as subgraph-shaped placeholders.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/api/polls.ts
@rickstaa
rickstaa merged commit 6a167af into main Jul 22, 2026
9 of 10 checks passed
@rickstaa
rickstaa deleted the revert-749-fix/lip118-onchain-poll-tally branch July 22, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants