Revert "fix: temporarily compute the LIP-118 tally on-chain while the subgraph resyncs"#750
Conversation
… subgrap…" This reverts commit 98f5694.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Reverts the temporary “compute poll tally on-chain” stopgap (introduced while the subgraph was behind) now that the subgraph has finished indexing again.
Changes:
- Removes the API route, types, and helper that computed/served poll tallies directly from chain state.
- Removes the client SWR hook and UI-side wiring that overlaid on-chain tallies / “did I vote?” state for manual polls.
- Simplifies manual poll entries to be subgraph-shaped placeholders without on-chain tally metadata.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pages/voting/[poll].tsx | Removes manual on-chain tally/vote fallback logic and updates the “indexing” notice copy. |
| pages/api/polls/tally/[poll].ts | Deletes the temporary API endpoint that served on-chain computed tallies. |
| lib/api/types/get-poll-tally.ts | Deletes the temporary PollTally types used by the stopgap endpoint/hook. |
| lib/api/pollTally.ts | Deletes the on-chain tally computation implementation. |
| lib/api/polls.ts | Removes the on-chain total-stake fallback and keeps only subgraph-based total stake fetching. |
| hooks/useSwr.tsx | Removes the useManualPollTally SWR hook. |
| constants/manualPolls.ts | Removes manual poll startBlockL2 / tally-overlay helper, leaving manual polls as subgraph-shaped placeholders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reverts #749 when subgraph is done indexing (see livepeer/subgraph#247)).