fix: map remaining livekit.DisconnectReason to SDK's DisconnectReason #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few entries in livekit.DisconnectReason are not explicitly mapped to the SDK's DisconnectReason. This causes them to be flagged as "OtherReason", even though some of them could be useful if explicitly mapped. e.g.: ROOM_DELETED, MIGRATION, SERVER_SHUTDOWN, CONNECTION_TIMEOUT mean different things and may be treated differently. Map ROOM_DELETED, MIGRATION and SERVER_SHUTDOWN to unique reasons. Map CONNECTION_TIMEOUT and SIP_TRUNK_FAILURE to `Failed`. The only remaining livekit.DisconnectReason is UNKNOWN_REASON, which makes sense as `OtherReason`.
prlanzarin
force-pushed
the
lkgosdk/fix/extra-discon-reasons
branch
from
0f5b92f to
3b14460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few entries in livekit.DisconnectReason are not explicitly mapped to
the SDK's DisconnectReason. This causes them to be flagged as
"OtherReason", even though some of them could be useful if explicitly
mapped. e.g.: ROOM_DELETED, MIGRATION, SERVER_SHUTDOWN,
CONNECTION_TIMEOUT mean different things and may be treated differently.
Map ROOM_DELETED, MIGRATION and SERVER_SHUTDOWN to unique reasons.
Map CONNECTION_TIMEOUT and SIP_TRUNK_FAILURE to
Failed.The only remaining livekit.DisconnectReason is UNKNOWN_REASON, which
makes sense as
OtherReason.