Skip to content

ci: fix publish workflow version reading #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theomonnom merged 2 commits into from
Apr 8, 2026
Merged

ci: fix publish workflow version reading #603

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b6a36d
ci: fix version reading — use --print-version flag instead of inline …
theomonnom Apr 8, 2026
ac29dd6
ci: remove unused sys import
theomonnom Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion .github/update_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import pathlib
import re
import sys

Check failure on line 3 in .github/update_versions.py

View workflow job for this annotation

GitHub Actions / build

ruff (F401) 

.github/update_versions.py:3:8: F401 `sys` imported but unused
  help: Remove unused import: `sys`
import click
from packaging.version import Version

Expand All @@ -9,6 +10,12 @@
"livekit-protocol": "livekit-protocol/livekit/protocol/version.py",
}

TAG_PREFIXES = {
"livekit": "rtc",
"livekit-api": "api",
"livekit-protocol": "protocol",
}


def _esc(*codes: int) -> str:
return "\033[" + ";".join(str(c) for c in codes) + "m"
Expand Down Expand Up @@ -117,7 +124,22 @@
default="patch",
help="Type of version bump.",
)
def bump(package: str, pre: str, bump_type: str) -> None:
@click.option(
"--print-version",
is_flag=True,
default=False,
help="Print current version and tag prefix, don't bump.",
)
def bump(package: str, pre: str, bump_type: str, print_version: bool) -> None:
if print_version:
vf = pathlib.Path(PACKAGES[package])
version = read_version(vf)
tag_prefix = TAG_PREFIXES[package]
# Output as key=value for easy parsing
print(f"version={version}")
print(f"tag_prefix={tag_prefix}")
return

if pre == "none":
do_bump(package, bump_type)
else:
Expand Down
17 changes: 2 additions & 15 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@ permissions:
pull-requests: write
id-token: write

env:
# Map PyPI package names to tag prefixes
# livekit -> rtc, livekit-api -> api, livekit-protocol -> protocol
TAG_PREFIX_MAP: '{"livekit":"rtc","livekit-api":"api","livekit-protocol":"protocol"}'
VERSION_FILE_MAP: '{"livekit":"livekit-rtc/livekit/rtc/version.py","livekit-api":"livekit-api/livekit/api/version.py","livekit-protocol":"livekit-protocol/livekit/protocol/version.py"}'

jobs:
# ── Step 1: Create a version bump PR ──────────────────────────
bump:
Expand Down Expand Up @@ -109,17 +103,10 @@ jobs:
env:
INPUT_PACKAGE: ${{ inputs.package }}
run: |
pkg="$INPUT_PACKAGE"
version_file=$(echo '${{ env.VERSION_FILE_MAP }}' | jq -r --arg pkg "$pkg" '.[$pkg]')
version=$(python -c "
import re, pathlib
m = re.search(r'__version__\s*=\s*[\"'\''](.*?)[\"'\'']', pathlib.Path('${version_file}').read_text())
print(m.group(1))
")
tag_prefix=$(echo '${{ env.TAG_PREFIX_MAP }}' | jq -r --arg pkg "$pkg" '.[$pkg]')
eval "$(python .github/update_versions.py --package "$INPUT_PACKAGE" --print-version)"
echo "version=$version" >> "$GITHUB_OUTPUT"
echo "tag_prefix=$tag_prefix" >> "$GITHUB_OUTPUT"
echo "Package: $pkg, New version: $version, Tag: ${tag_prefix}-v${version}"
echo "Package: $INPUT_PACKAGE, New version: $version, Tag: ${tag_prefix}-v${version}"

- name: Close existing release PRs for this package
env:
Expand Down
Loading