feat(simulate): fail CI only on new baseline regressions - #954
Open
u9g wants to merge 3 commits into
Open
Conversation
lk agent simulate --baseline <run-id> fetches that finished run and diffs failed scenarios (matched by label, or instructions when unlabeled): failures the baseline already had are reported but no longer fail the exit code, so CI only breaks on regressions. Systemic run failures and unfetchable baselines still fail loudly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lk agent simulate --baseline <run-id>so CI fails only for scenarios that did not fail in the baseline--run-id-file <path>so CI can persist the newly created run ID even when the simulation later failsCI usage
Store the latest accepted main-branch run ID in a CI variable or artifact, then run:
Only a successful main-branch run should replace the stored baseline with the ID from
--run-id-file. Pull requests and failed main runs must leave it unchanged. For the first run, omit--baseline, inspect and accept the result, then store the emitted ID.Test plan
go test ./cmd/lkgo vet ./cmd/lkgit diff --check