Skip to content

Transceiver leak (only for video tracks) #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2025
Merged

Transceiver leak (only for video tracks) #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a9972b
Stop only for video tracks
pblazej Sep 1, 2025
574a90f
Update webrtc
pblazej Sep 3, 2025
33a6a51
Change
pblazej Sep 1, 2025
ba72f8b
Move video check
pblazej Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/transceiver-refix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
patch type="fixed" "Restrict transceiver memory leak fix to video tracks"
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ let package = Package(
],
dependencies: [
// LK-Prefixed Dynamic WebRTC XCFramework
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "137.7151.04"),
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "137.7151.05"),
.package(url: "https://github.com/apple/swift-protobuf.git", from: "1.29.0"),
.package(url: "https://github.com/apple/swift-log.git", from: "1.6.2"),
.package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
Expand Down
2 changes: 1 addition & 1 deletion [email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ let package = Package(
],
dependencies: [
// LK-Prefixed Dynamic WebRTC XCFramework
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "137.7151.04"),
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "137.7151.05"),
.package(url: "https://github.com/apple/swift-protobuf.git", from: "1.29.0"),
.package(url: "https://github.com/apple/swift-log.git", from: "1.6.2"),
.package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
Expand Down
13 changes: 13 additions & 0 deletions Sources/LiveKit/Core/Transport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,19 @@ extension Transport {
guard _pc.removeTrack(sender) else {
throw LiveKitError(.webRTC, message: "Failed to remove track")
}

releaseTransceiver(sender: sender)
}

// Try to stop the transceiver and free the resources
// Workaround: https://groups.google.com/g/discuss-webrtc/c/WDsGuVucBjQ?pli=1
private func releaseTransceiver(sender: LKRTCRtpSender) {
if let transceiver = _pc.transceivers.first(where: { $0.sender == sender }),
transceiver.mediaType == .video, !transceiver.isStopped
{
log("Stopping video transceiver", .debug)
transceiver.stopInternal()
}
}

func dataChannel(for label: String,
Expand Down
Loading