Skip to content

Conversation

hiroshihorie
Copy link
Member

No description provided.

@hiroshihorie
Copy link
Member Author

We need to test if I didn't break anything here 🙂

@hiroshihorie hiroshihorie requested a review from pblazej September 1, 2025 09:03
@pblazej
Copy link
Contributor

pblazej commented Sep 2, 2025

Vibe-coded a quick prototype according to README livekit-examples/swift-example#77

It works well with one mode, but switching between manual/mic gives me either Engine is not running or a crash (on iOS). What am I doing wrong?

BTW maybe it's worth converting into a "proper panel" for future testing - feel free to destroy it 👍

@hiroshihorie
Copy link
Member Author

We don't really support switching manual / device rendering mode at runtime, it's a complicated internal switch... although ideally it should work.

@pblazej
Copy link
Contributor

pblazej commented Sep 2, 2025

We don't really support switching manual / device rendering mode at runtime, it's a complicated internal switch... although ideally it should work.

Maybe assertionFailure would be better in this case?

@pblazej
Copy link
Contributor

pblazej commented Sep 2, 2025

@hiroshihorie
Copy link
Member Author

Yes I think the options are:

  1. Make it settable once only like ADM type.
  2. Simply fix the AVAudioEngine ADM to be able to switch at run time. I think the errors you see are from the attached nodes in MixerEngineObserver.swift. I think the node attach/cleanup lifecycle is not working.

@hiroshihorie
Copy link
Member Author

@pblazej Yes I think 0.4 is already being used.

@pblazej
Copy link
Contributor

pblazej commented Sep 2, 2025

Make it settable once only like ADM type.

I think this is perfectly fine for now.

@pblazej
Copy link
Contributor

pblazej commented Sep 3, 2025

Started getting Room.signalClient(_:didSubscribeTrack:) Could not find local track publication for subscribed event in manual mode, anything wrong with the example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants