Add outputVolume property to audio mixer
#739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pblazej
reviewed
Jul 22, 2025
|
|
||
| // Reference to mainMixerNode | ||
| weak var mainMixerNode: AVAudioMixerNode? | ||
| var outputVolume: Float = 1.0 |
There was a problem hiding this comment.
Hypothetically we could just read it from mainMixerNode defaulting ?? to 0 (as a computed prop). Less state, fewer errors.
There was a problem hiding this comment.
Thanks for noticing that, but my intention was that the user might want to mutate outputVolume before mainMixerNode is assigned to that variable, since it’s only first assigned when audio is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.