fix: tighten VideoTrackRenderer Widget #695
Conversation
|
tests fail due to required changes in flutter-webrtc and webrtc-interface not being merged yet |
|
I just realized that I should probably move the sized box up the chain to |
|
This PR will be merged after the new flutter-webrtc is released |
|
I tested this PR and found that it broke the fit setting in VideoTrackRenderer. when I publish a video track from the portrait viewfinder on a mobile Original code 
RTCVideoViewObjectFitCover Modification from this PR RTCVideoViewObjectFitContain RTCVideoViewObjectFitCover As shown in the screenshot, PR broke the centering of widgets and the rendering of the RTCVideoViewObjectFitCover mode |
|
oh right, I didn't test with the cover option. All my sizing should be ignored in cover option as the widget will fill up all available space anyway. I'll push a fix soon |
This allows external users to e.g. apply rounded edges. Without this patch, VideoTrackRenderer will expand to its available space with no way for parent widgets to know how large the video actually is
also, cover all paths by moving up sizing logic to build function
holzgeist
force-pushed
the
video-size-constraint
branch
from
18c5f03 to
32b8b0a
Compare
holzgeist
force-pushed
the
video-size-constraint
branch
2 times, most recently
from
a722a19 to
8daa6b0
Compare
|
Hi @cloudwebrtc what's the reason for closing this? I added the fix you requested. (Though now I see that I didn't ping you about it..) |
|
I think this PR breaks the existing layout, this is the main branch layout This branch causes the position of the video widgets to shift, the video view is always docked in the upper left corner. You can try dragging the window and changing the video size, and the video should always be displayed in the center. |
|
oh, sorry about that! I did test both options with my app, but not with the example app. I'll fix it and ping you here to reopen the PR (if I get it to work :) ) |
|
It works with the example app now (tested on native linux and web). The initial issue was that flutter-webrtc wraps the whole view in a center, preventing any "insights" into the actual size. My PR "removes" that Center by wrapping in a LayoutBuilder and SizedBox. |
|
@cloudwebrtc should I open another PR or can you reopen this one? It looks like I can't reopen it |
|
The build failure for android does not seem to be connected to my changes, the PR should be ready for review now |
This allows external users to e.g. apply rounded edges. Without this patch, VideoTrackRenderer will expand to its available space with no way (known to me..) for parent widgets to know how large the video actually is.
depends on flutter-webrtc/flutter-webrtc#1754 (and flutter-webrtc/webrtc-interface#30)