livekit_bridge: An ergonomic interface into the Livekit C++ SDK#58
Open
stephen-derosa wants to merge 19 commits intolivekit:mainfrom
Open
livekit_bridge: An ergonomic interface into the Livekit C++ SDK#58stephen-derosa wants to merge 19 commits intolivekit:mainfrom
stephen-derosa wants to merge 19 commits intolivekit:mainfrom
Conversation
|
|
Collaborator
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
Good work, that is a large PR, I will need more time to review it.
some initial questions to get a clearer picture on the design.
…s. livekit_bridge.cpp: disconnect() if cerr, but continue with disconnect
…ing_ flag to guard against calling connect() more than once
instead of calling stopThread() before creating, we do cleanup after calling start.
examples/robot.cpp for sends webcam/mic and sim video/audio feeds to the human participant. examples/human.cpp takes in human input to switch between real/sim streams
stephen-derosa
force-pushed
the
feat/livekit_cpp_bridge.sdd
branch
2 times, most recently
from
f7ef724 to
1f5e7fd
Compare
stephen-derosa
force-pushed
the
feat/livekit_cpp_bridge.sdd
branch
from
1f5e7fd to
baf78ba
Compare
Collaborator
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
Great work!
LGTM with some suggestions offline.
…sconnect(). Application must call release() to unpublish tracks. TODO: handle remote disconencts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
An ergonomic library providing simple usage of the C++ SDK.
Building
This library is attached to the build system of the core C++ SDK library. Use
build.shas is.Testing
The
bridge/examples/directory has simulatedhumanandrobottests. There are 4 files:These have been tested manually.
Unit tests
CallbackKeyhashing/equality,BridgeAudioTrack/BridgeVideoTrackstate management, andLiveKitBridgepre-connection behaviour (callback registration, error handling).Limitations
The bridge is designed for simplicity and currently only supports limited audio and video features. It does not expose:
RoomOptionsorTrackPublishOptionsFor advanced use cases, use the full
client-sdk-cppAPI directly, or expand the bridge to support your use case.TODOs before merge