Repository navigation
Conversation
ladvoc
commented
Oct 7, 2026
| return room.listener_id_; | ||
| } | ||
|
|
||
| static void simulateScenario(Room& room, proto::SimulateScenarioKind scenario) { |
Contributor
Author
There was a problem hiding this comment.
question: Do we need this?
| const auto& ltr = re.local_track_republished(); | ||
| const std::string& previous_sid = ltr.previous_sid(); | ||
|
|
||
| auto& published = local_participant_->published_tracks_by_sid_; |
Collaborator
There was a problem hiding this comment.
Nit: variable name for the data type, maybe published_list or published_set (depending on what published_tracks_by_sid_ is)
alan-george-lk
approved these changes
Oct 8, 2026
alan-george-lk
left a comment
alan-george-lk
left a comment
Collaborator
There was a problem hiding this comment.
LGTM pending comments
| LK_LOG_ERROR("kLocalTrackRepublished: local_participant_ is nullptr"); | ||
| break; | ||
| } | ||
| const auto& ltr = re.local_track_republished(); |
Collaborator
There was a problem hiding this comment.
Nit: variable name, maybe local_track_repub
Comment on lines
+636
to
+651
| auto it = published.find(previous_sid); | ||
| if (it == published.end()) { | ||
| LK_LOG_WARN("local_track_republished for unknown previous sid: {}", previous_sid); | ||
| break; | ||
| } | ||
| auto track = it->second.lock(); | ||
| if (!track) { | ||
| published.erase(it); | ||
| LK_LOG_WARN("local_track_republished for expired previous sid: {}", previous_sid); | ||
| break; | ||
| } | ||
| auto publication = localTrackPublication(track); | ||
| if (!publication) { | ||
| LK_LOG_WARN("local_track_republished missing publication for sid: {}", previous_sid); | ||
| break; | ||
| } |
Collaborator
There was a problem hiding this comment.
In these cases do we just lose the track entirely given the break on each? Is that intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BOT-568