chore: update rust-sdks to livekit-ffi v0.12.68#187
Open
xianshijing-lk wants to merge 3 commits into
Open
Conversation
Updates rust-sdks submodule to include: - Add MaintainFramerateAndResolution to DegradationPreference enum (aligns with WebRTC M144) - DISABLED is deprecated, use MAINTAIN_FRAMERATE_AND_RESOLUTION instead Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
xianshijing-lk
requested review from
alan-george-lk and
stephen-derosa
as code owners
Add DegradationPreference enum and field to TrackPublishOptions to allow controlling encoder behavior when bandwidth is constrained: - Balanced: Balance between framerate and resolution degradation - MaintainFramerate: Degrade framerate to maintain resolution - MaintainResolution: Degrade resolution to maintain framerate - Disabled (deprecated): Use MaintainFramerateAndResolution instead - MaintainFramerateAndResolution: Maintain both, drop frames before encoding Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
xianshijing-lk
force-pushed
the
sxian/update-ffi-0.12.68
branch
from
70b468b to
d0a4d24
Compare
The docstrings for MaintainFramerate and MaintainResolution were swapped. Per the W3C WebRTC spec: - MaintainFramerate: Degrade resolution to maintain framerate (prioritize smooth motion) - MaintainResolution: Degrade framerate to maintain resolution (prioritize image clarity) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
stephen-derosa
left a comment
stephen-derosa
left a comment
Collaborator
There was a problem hiding this comment.
LGTM other than the clang requets
Collaborator
|
@xianshijing-lk Thanks for the add, however I believe this release needs the I was waiting on the release and just updated the submodule/tested locally. |
Collaborator
|
@xianshijing-lk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates rust-sdks submodule to livekit-ffi v0.12.68.
Changes
MaintainFramerateAndResolutiontoDegradationPreferenceenum (aligns with WebRTC M144)DISABLEDis deprecated, useMAINTAIN_FRAMERATE_AND_RESOLUTIONinstead🤖 Generated with Claude Code