fix(voice): stop recreating STT stream on non-retryable errors - #7173
Closed
phillip-kil wants to merge 4 commits into
Closed
fix(voice): stop recreating STT stream on non-retryable errors#7173phillip-kil wants to merge 4 commits into
phillip-kil wants to merge 4 commits into
Conversation
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
221
to
224
| logger.warning( | ||
| "STT stream ended on an unrecoverable error, recreating", | ||
| "STT stream ended on a retryable error, recreating", | ||
| exc_info=True, | ||
| ) |
Contributor
There was a problem hiding this comment.
🟨 STT exceptions bypass log redaction
Retryable failures log exc_info=True, exposing the API exception and its cause chain. Provider errors can contain customer audio metadata, response payloads, headers, or credentials. Tracebacks cannot be redacted through a PII-tagged field.
Was this helpful? React with 👍 or 👎 to provide feedback.
Author
There was a problem hiding this comment.
This is not a regression introduced by this PR, so I'd leave this as is.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_STTPipeline._stt_pumpinlivekit-agents/livekit/agents/voice/audio_recognition.pyrecreates stream on every APIError regardless of APIError.retryable. So we are applying retries on permanent failures until the retries are exhausted.The code already describes the intended behaviour to stop on
retryable=False, but does not apply the condition anywhere.This is the only pump that ignores retryable.
llm/llm.py:316,stt/stt.py:246,477,inference/interruption.py:466andinference/eot/transports.py:287all check the property before retrying.Addresses #7172