send ServerInfo to CLI host on start#6260
Open
davidzhao wants to merge 2 commits into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
theomonnom
reviewed
Jun 27, 2026
Comment on lines
+54
to
+62
| server_info_cls = getattr(agent_dev, "ServerInfo", None) | ||
| if server_info_cls is not None: | ||
| info = agent_dev.AgentDevMessage( | ||
| server_info=server_info_cls( | ||
| agent_name=self._worker._agent_name, | ||
| url=self._worker._ws_url, | ||
| ) | ||
| ) | ||
| await _send_proto(writer, info.SerializeToString()) |
Member
There was a problem hiding this comment.
Should you just bump the protocol instead?
Member
There was a problem hiding this comment.
proto defaults to None/empty already?
Member
Author
There was a problem hiding this comment.
where do you define protocol version? I didn't see it anywhere
Member
There was a problem hiding this comment.
No I mean, the livekit-protocol package, it's fine to directly access agent_dev.ServerInfo if you bump? Instead of getattr
theomonnom
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.