fix: nest endpointingSensitivity under endpointing in sessionStart#6248
Open
C1-BA-B1-F3 wants to merge 1 commit into
Open
fix: nest endpointingSensitivity under endpointing in sessionStart#6248C1-BA-B1-F3 wants to merge 1 commit into
C1-BA-B1-F3 wants to merge 1 commit into
Conversation
Nova Sonic 2 API rejects sessionStart when endpointingSensitivity is placed at the top level. It must be nested under an 'endpointing' key. Fixes livekit#6200 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+98
to
+104
| class Endpointing(BaseModel): | ||
| endpointingSensitivity: TURN_DETECTION | None = "MEDIUM" | ||
|
|
||
|
|
||
| class SessionStart(BaseModel): | ||
| inferenceConfiguration: InferenceConfiguration | ||
| endpointingSensitivity: TURN_DETECTION | None = "MEDIUM" | ||
| endpointing: Endpointing |
Contributor
There was a problem hiding this comment.
🚩 Schema change is a breaking wire-format change for the AWS API
This PR changes the serialized JSON structure sent to the AWS Nova Sonic API. Previously the session start event contained "endpointingSensitivity": "MEDIUM" at the top level of sessionStart. Now it emits "endpointing": {"endpointingSensitivity": "MEDIUM"}. This is a breaking wire-format change — if the AWS API has not been updated to accept this new schema, sessions will fail to start. Since this is an external API contract, correctness cannot be verified from the codebase alone.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When starting a Nova Sonic 2 session, the
sessionStartevent is rejected by the API becauseendpointingSensitivityis placed at the top level ofsessionStart. The Nova Sonic 2 API expects it nested under anendpointingkey.Fix
EndpointingPydantic model with theendpointingSensitivityfieldSessionStartmodel to useendpointing: Endpointinginstead ofendpointingSensitivityat the top levelSonicEventBuilder.create_session_start_event()to construct the nested structureBefore (rejected)
{ "sessionStart": { "inferenceConfiguration": {...}, "endpointingSensitivity": "MEDIUM" } }After (correct)
{ "sessionStart": { "inferenceConfiguration": {...}, "endpointing": { "endpointingSensitivity": "MEDIUM" } } }Fixes #6200