Skip to content

feat(core): allow skip_reply when calling commit_user_turn#5066

Merged
chenghao-mou merged 1 commit intomainfrom
chenghao/feat/skip-reply-when-commit
Mar 10, 2026
Merged

feat(core): allow skip_reply when calling commit_user_turn#5066
chenghao-mou merged 1 commit intomainfrom
chenghao/feat/skip-reply-when-commit

Conversation

@chenghao-mou
Copy link
Member

Expose skip_reply at session level for both realtime and cascading agents when calling commit_user_turn.

closes #5026

This can be tested with a RPC:

    @ctx.room.local_participant.register_rpc_method("commit_user_turn")
    async def on_commit_user_turn(data: rtc.RpcInvocationData) -> str:
        skip_reply = data.payload == "skip_reply"
        logger.info(f"RPC commit_user_turn called, skip_reply={skip_reply}")
        fut = session.commit_user_turn(skip_reply=skip_reply)
        transcript = await fut
        logger.info(f"Committed transcript: {transcript}")
        return transcript

Expose skip_reply at session level for both realtime and cascading agents when calling commit_user_turn.

closes #5026
@chenghao-mou chenghao-mou requested a review from a team March 10, 2026 10:57
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@chenghao-mou chenghao-mou merged commit 0511e30 into main Mar 10, 2026
20 checks passed
@chenghao-mou chenghao-mou deleted the chenghao/feat/skip-reply-when-commit branch March 10, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: commit_user_turn() without automatic response generation

2 participants