Skip to content

fix(aws): improve credential handling and client lifecycle (#1719) - Version 0.x #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 0.x
Choose a base branch
from

Conversation

andormarkus
Copy link
Contributor

This PR addresses issue #1719 by improving AWS credential handling and client lifecycle management across the AWS plugin.

Key changes:

  • Store AWS credentials in instance instead of global env vars to prevent credential leakage
  • Use async context managers for AWS clients to ensure proper resource cleanup
  • Add proper credential validation to fail fast if credentials are invalid
  • Fix session token handling for temporary credentials
  • Ensure proper resource cleanup across all AWS services

The changes make the code more robust, safer, and consistent across all AWS services while properly handling async operations.

@jayeshp19
Copy link
Contributor

Hey I've done some cleanup and created a PR: #1849. Let me know if it meets your requirements :)

@andormarkus
Copy link
Contributor Author

Hi @jayeshp19

We solved the credentials issue for version 1.x via #1849.
This PR is for version 0.x. Should I backport the code from 1.0 into 0.x ?

@jayeshp19
Copy link
Contributor

Hi @jayeshp19

We solved the credentials issue for version 1.x via #1849. This PR is for version 0.x. Should I backport the code from 1.0 into 0.x ?

Hi That'd be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants