Skip to content

chore(deps): update dependency js-yaml@<3.15.0 to v4 [security] #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidzhao merged 1 commit into from
Aug 20, 2026
+12 −18
Merged

chore(deps): update dependency js-yaml@<3.15.0 to v4 [security] #2271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ minimumReleaseAgeExclude:
- '@opentelemetry/core@2.8.0'
# Renovate security update: brace-expansion@5.0.8
- brace-expansion@5.0.8
# Renovate security update: js-yaml@4.3.1
- js-yaml@4.3.1

catalog:
'@livekit/rtc-node': ^0.13.34
Expand All @@ -37,7 +39,7 @@ overrides:
'lodash@<4.18.0': ^4.18.0
'protobufjs@<7.6.5': ^7.6.5
'ws@>=8.0.0 <8.21.0': ^8.21.0
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.

@devin-ai-integration devin-ai-integration Bot Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Release tooling can crash because a dependency is forced onto an incompatible new YAML library version

Packages that only work with the 3.x line of the YAML parser are now forced onto the 4.x line ('js-yaml@<3.15.0': ^4.3.1 at pnpm-workspace.yaml:41), so tooling that still calls the old, removed reading function fails at runtime.
Impact: The changesets-based versioning/release commands can fail with a "not a function" error, blocking releases and CI.

Override forces js-yaml 4 into read-yaml-file@1.1.0, which calls the removed safeLoad API

The lockfile shows the only consumer previously resolved through the js-yaml@<3.15.0 override is read-yaml-file@1.1.0 (pnpm-lock.yaml:8957-8962), which now resolves js-yaml: 4.3.1 instead of 3.15.0. read-yaml-file@1.1.0 declares js-yaml ^3.6.1 and parses with yaml.safeLoad(...); safeLoad/safeDump were removed in js-yaml 4.0.0 (see the breaking-change list in the PR description: "removed safe* functions"). Calling it therefore throws TypeError: yaml.safeLoad is not a function.

read-yaml-file@1.1.0 is pulled in by @manypkg/get-packages@1.1.3 (pnpm-lock.yaml:6297-6304), which is used by the changesets CLI to discover workspace packages — the repo relies on changesets for versioning (patchedDependencies for @changesets/assemble-release-plan in pnpm-workspace.yaml:29-30).

A safer fix is to keep the 3.x branch on a patched 3.x release (or bump read-yaml-file/@manypkg/get-packages to a version compatible with js-yaml 4) rather than cross the major boundary via an override.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
'js-yaml@<3.15.0': ^3.15.0
'js-yaml@<3.15.0': ^4.3.1
'js-yaml@>=4.0.0 <4.3.0': ^4.3.0
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.

@devin-ai-integration devin-ai-integration Bot Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟨 Vulnerable js-yaml 4.3.0 remains installed after the security update

This PR bumps only the <3.15.0 branch of the js-yaml override to ^4.3.1, while the 4.x branch override still targets ^4.3.0 (pnpm-workspace.yaml:43). The lockfile consequently keeps resolving js-yaml: 4.3.0 for several dependencies (pnpm-lock.yaml:5725, pnpm-lock.yaml:5935, pnpm-lock.yaml:7840), and 4.3.0 is the version listed as affected by GHSA-5p4m-2wfm-xmqj (quadratic CPU consumption in !!omap resolution). The advisory's DoS exposure therefore persists in the dependency tree the update was intended to remediate.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

'minimatch@<3.1.3': ^3.1.3
'minimatch@>=9.0.0 <9.0.7': ^9.0.7
Expand Down
Loading