Skip to content

fix(agents): stop forwarding frame processor info#1883

Closed
rosetta-livekit-bot[bot] wants to merge 1 commit into
mainfrom
unhooks-hitter-affirms
Closed

fix(agents): stop forwarding frame processor info#1883
rosetta-livekit-bot[bot] wants to merge 1 commit into
mainfrom
unhooks-hitter-affirms

Conversation

@rosetta-livekit-bot

@rosetta-livekit-bot rosetta-livekit-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Testing

  • pnpm exec tsc -p agents/tsconfig.json --noEmit
  • pnpm test agents/src/voice/room_io/room_io.test.ts

Ported from livekit/agents#5867

Original PR description

Delegate sending stream info to the frame processor to the client sdk AudioStream instead of doing it all at the agents sdk level.

Depends on livekit/python-sdks#679 - all the FrameProcessor-related code removed in here has been moved into the underlying python sdk.

TODO

@changeset-bot

changeset-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 61bff05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@livekit/agents Patch
@livekit/agents-plugin-anam Patch
@livekit/agents-plugin-assemblyai Patch
@livekit/agents-plugin-baseten Patch
@livekit/agents-plugin-bey Patch
@livekit/agents-plugin-cartesia Patch
@livekit/agents-plugin-cerebras Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-did Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-fishaudio Patch
@livekit/agents-plugin-google Patch
@livekit/agents-plugin-hedra Patch
@livekit/agents-plugin-hume Patch
@livekit/agents-plugin-inworld Patch
@livekit/agents-plugin-lemonslice Patch
@livekit/agents-plugin-liveavatar Patch
@livekit/agents-plugin-livekit Patch
@livekit/agents-plugin-minimax Patch
@livekit/agents-plugin-mistral Patch
@livekit/agents-plugin-mistralai Patch
@livekit/agents-plugin-neuphonic Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-perplexity Patch
@livekit/agents-plugin-phonic Patch
@livekit/agents-plugin-resemble Patch
@livekit/agents-plugin-rime Patch
@livekit/agents-plugin-runway Patch
@livekit/agents-plugin-sarvam Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugin-soniox Patch
@livekit/agents-plugin-tavus Patch
@livekit/agents-plugins-test Patch
@livekit/agents-plugin-trugen Patch
@livekit/agents-plugin-xai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rosetta-livekit-bot rosetta-livekit-bot Bot requested a review from 1egoman June 25, 2026 19:13
@1egoman

1egoman commented Jun 25, 2026

Copy link
Copy Markdown

Duplicate of #1881, closing.

@1egoman 1egoman closed this Jun 25, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

token: this.room.token!,
url: this.room.serverUrl!,
});
return true;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 FrameProcessor no longer receives stream context or credentials after track subscription

The removed code at agents/src/voice/room_io/_input.ts:155-164 (old lines) forwarded participant identity, room name, publication SID, token, and server URL to the FrameProcessor whenever a new track was subscribed, and refreshed credentials on token refresh. After this PR, the FrameProcessor still receives audio frames via AudioStream (agents/src/voice/room_io/_input.ts:159-164), but it no longer has access to the stream metadata or LiveKit credentials. If any FrameProcessor implementation (e.g., a cloud-based noise cancellation service) relies on these callbacks to authenticate or route audio, it would silently stop working. The changeset description explicitly states this is intentional, so this is likely coordinated with an update in @livekit/rtc-node where AudioStream now handles this internally. Worth confirming with the rtc-node team that the FrameProcessor contract no longer requires these calls.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant